Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pages to remove deactivated families #1872

Closed
simonkp opened this issue Feb 9, 2017 · 2 comments
Closed

Update pages to remove deactivated families #1872

simonkp opened this issue Feb 9, 2017 · 2 comments
Assignees
@simonkp
Labels
enhancement
Milestone
2.7.0

Comments

@simonkp
Copy link

simonkp commented Feb 9, 2017 •
edited by bradgearon
Loading

Update menu page queries to remove deactivated families from various lists.
@simonkp simonkp mentioned this issue Feb 10, 2017
Closed
@simonkp simonkp changed the title Update menu page to remove deactivated families Update pages to remove deactivated families Feb 10, 2017
@simonkp
Copy link
Author

simonkp commented Feb 10, 2017

Add the following pages to the list to remove deactivated families
FamilyList.php
SelectList.php

bradgearon added a commit to bradgearon/ChurchCRM that referenced this issue Feb 23, 2017
@bradgearon
resolves ChurchCRM#1872
ca52442
@bradgearon bradgearon self-assigned this Feb 23, 2017
@bradgearon bradgearon assigned simonkp and unassigned bradgearon Feb 23, 2017
@bradgearon
Copy link

I accidentally tried to fix this again. Please ignore that :)

@simonkp simonkp mentioned this issue Mar 4, 2017
Merged
@DawoudIO DawoudIO added this to the 2.7.0 milestone Mar 8, 2017
DawoudIO pushed a commit that referenced this issue Mar 13, 2017
@simonkp @DawoudIO
#1872 update pages for deactivated families (#2046)
276c966 
* Update to dashboard page

* Addded functions to DashboardService to fetch the updated and latest
families and members.
* Converted queries to ORM and filtered out deactivated families.

fixes # 1872

* Add deactivated filter to Family view and person view pages.

* added filters to fetch only active families /members from active
families only to the  following pages.
-- FamilyList.php, SelectList.php

fixes #1872

* Deactivated (Inactive) families listing

Deactivated (Inactive) families listing #1873
* modified the FamilyView.php to handle inactive families listing by
passing ?mode=inactive

fixes #1873

* Review comment fixes

Review comment fixes

* Style CI fixes

Style CI fixes

* More StyleCI fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonkp simonkp

Labels
enhancement
Projects
None yet
Milestone
2.7.0
Development

No branches or pull requests
3 participants
@DawoudIO @bradgearon @simonkp