Fix broken lint and add it to GH Actions #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cortinico
added
the
infra
cortinico
force-pushed
the
nc/fix-lint
branch
from
a4be0a0 to
16af1a1
Compare
vbuberen
reviewed
Nov 28, 2020
|
|
Understood. Wanted to be sure. |
koral--
reviewed
Nov 29, 2020
| <!-- Default screen margins, per the Android Design guidelines. --> | ||
| <dimen name="norm_grid_size">8dp</dimen> | ||
| <dimen name="norm_grid_size" tools:ignore="UnusedResources">8dp</dimen> |
There was a problem hiding this comment.
Why it is ignored?
Shouldn't be just removed if it is really unused?
Or maybe it is preserved for backwards compatibility?
There was a problem hiding this comment.
Why it is ignored?
It's ignored as it's our base grid size. All the others size are derived from this. I'd rather keep it otherwise doub_grid_size would make little sense
MiSikora
approved these changes
Nov 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Context
Lint is currently broken on
develop. I'm fixing it and I've added a job on GH Actions to run it on pre-merge. If you happen to rungw checkto run all the verifications, it will fail.📝 Changes
AcceptsUserCertificatesas we intentionally want to allow user CAsandroid:networkSecurityConfig⏱️ Next steps
I believe we should update the pre-commit hook to run
gw check