Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OkHttp and bump min SDK to 21 #500

Merged
merged 4 commits into from
Nov 15, 2020
Merged

Update OkHttp and bump min SDK to 21 #500

merged 4 commits into from
Nov 15, 2020

Conversation

MiSikora
Copy link
Contributor

@MiSikora MiSikora commented Nov 11, 2020 •
edited
Loading

📄 Context

This is a consequence of updating OkHttp that is planned for Chucker 4.x.

📝 Changes

  • Bump OkHttp to 4.9.0 and replace deprecated methods.
  • Bump Retrofit to 2.9.0.
  • Fix Lint issues due to min SDK bump (and some other minor ones).
  • Remove OkHttp and Retrofit from Dependabot ignore list.
  • Update README about Java 8 support.
  • Enable Java 8 in the sample.

🚫 Breaking

Yes, min SDK is higher and Java 8 support is needed, but this is expected.

🛠️ How to test

Not sure. Run the app and check it? Otherwise let the CI do its job.

⏱️ Next steps

Maybe enable Lint checks on GH Actions?

@MiSikora MiSikora added infra Issue or pull request relate to the library infrastructure (CI, Release mgmt, etc.) dependencies Pull requests that update a dependency file labels Nov 11, 2020
@MiSikora MiSikora added this to the 4.0.0 milestone Nov 11, 2020
@MiSikora MiSikora force-pushed the okhttp-4 branch 2 times, most recently from 1adde95 to 03a3bdf Compare November 11, 2020 16:01
cortinico
cortinico approved these changes Nov 11, 2020
View reviewed changes
Copy link
Member

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through the whole diff and it looks good on my end 👍

README.md Show resolved Hide resolved
@MiSikora
Upgrade min SDK to 21
ba1cd97 
- Bump OkHttp to 4.9.0 and replace deprecated methods.
- Bump Retrofit to 2.9.0.
- Fix Lint issues due to min SDK bump (and some other minor ones).
- Remove OkHttp and Retrofit from Dependabot ignore list.
vbuberen
vbuberen approved these changes Nov 14, 2020
View reviewed changes
Copy link
Collaborator

@vbuberen vbuberen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Had to check changelogs for OkHttp and Retrofit quite thoroughly, because such version jump is quite scary.

As to next steps - we could consider switching to OkHttp BOM.

CHANGELOG.md Outdated Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
library/build.gradle Show resolved Hide resolved
README.md Show resolved Hide resolved
@MiSikora
Copy link
Contributor Author

Ok, I updated PR with code review fixes and added info about Android 16+ to FAQ.

@MiSikora MiSikora merged commit ff2abf7 into develop Nov 15, 2020
@MiSikora MiSikora deleted the okhttp-4 branch November 15, 2020 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cortinico cortinico cortinico approved these changes

@vbuberen vbuberen vbuberen approved these changes

@olivierperez olivierperez Awaiting requested review from olivierperez

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file infra Issue or pull request relate to the library infrastructure (CI, Release mgmt, etc.)
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@MiSikora @cortinico @vbuberen