Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Dependabot config #372

Merged
merged 4 commits into from
Jul 3, 2020

Conversation

vbuberen
Copy link
Collaborator

@vbuberen vbuberen commented Jul 3, 2020

📄 Context

It seems that I introduced an invalid YAML for Dependabot in #371. This PR fix the issue.
Also, I found out that currently automatic milestones assignment accepts only integers, so we can't add 3.3.0 in the config, but 9 (the number of 3.3.0). Since 9 has no sense to most people it might be messed up and forgotten with time.
Aside from that I tried to add automatic reviewers assignment.

📝 Changes

  • Fixed indents in Dependabot config.
  • Removed milestone assignment.
  • Added reviewers assignment.

🚫 Breaking

Nothing

🛠️ How to test

Merge into develop

@vbuberen vbuberen added the infra Issue or pull request relate to the library infrastructure (CI, Release mgmt, etc.) label Jul 3, 2020
@vbuberen vbuberen added this to the 3.3.0 milestone Jul 3, 2020
@vbuberen vbuberen requested a review from cortinico July 3, 2020 09:19
@vbuberen vbuberen merged commit 7cbd9af into ChuckerTeam:develop Jul 3, 2020
@vbuberen vbuberen deleted the fix/dependabot_config branch August 3, 2020 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Issue or pull request relate to the library infrastructure (CI, Release mgmt, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants