Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit max lines for transaction list item path and host #312

Merged
merged 2 commits into from
Apr 7, 2020

Conversation

vbuberen
Copy link
Collaborator

@vbuberen vbuberen commented Apr 6, 2020

📄 Context

As reported in #310 some users have long queries and one item of transaction item might occupy a lot of screen space. To address this issue I suggest to limit path lines to 4 and host lines to 2. It should be enough for preview and shouldn't be critical, because user can always open the transaction to see the full path and host.
Also found out that Chucker missed ellipsize property for Toolbar title, which was limited by 2 lines already.

Closes #310

📝 Changes

  • Limited maxLines for transactions list item path to 4 lines.
  • Added ellipsize=end to list items and to Toolbar title

@vbuberen vbuberen requested a review from cortinico April 6, 2020 13:49
@vbuberen vbuberen added the enhancement New feature or improvement to the library label Apr 6, 2020
Copy link
Member

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍

@cortinico cortinico added this to the 3.3.0 milestone Apr 7, 2020
@vbuberen vbuberen merged commit 505f23c into ChuckerTeam:develop Apr 7, 2020
@vbuberen vbuberen deleted the fix/list_item_max_lines branch May 23, 2020 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement to the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long query parameters in request list
2 participants