Repository navigation
fix: avoid cumulative page title timeouts - #2775
Closed
dennisimoo wants to merge 1 commit into
Closed
dennisimoo wants to merge 1 commit into
dennisimoo wants to merge 1 commit into
Conversation
dennisimoo
marked this pull request as ready for review
September 19, 2026 02:57
Author
|
Could a maintainer approve the pending CI runs? The three regression tests and local lint/format checks pass. |
pull Bot
pushed a commit
to y1024/chrome-devtools-mcp
that referenced
this pull request
Sep 30, 2026
Closes ChromeDevTools#2775 I think runtime fetches are not worth the complication. Instead we should be able to rely on the CDP title state to differentiate targets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fetch page titles concurrently so the existing one-second timeouts overlap instead of adding up per unresponsive page. Reuses the current timeout and fallback, preserves output order, and skips hidden extension pages.
The mock-based regression reproduces three seconds of title-lookup delay before the fix and one second afterward. Tests cover extension visibility, out-of-order completion, and rejected lookups. This fixes cumulative title delay, not every cause of
list_pageshangs.Testing:
npm run test -- tests/McpResponse.pageTitles.test.ts(3 passed) andnpm run check-formatpassed. The full suite was attempted, then stopped after browser startup failures: this host has no usable Chrome sandbox and lacks stable Chrome for some tests.AI-assisted with OpenAI Codex.