Repository navigation
refactor: centralize config defaults and conflict checks - #2753
Merged
Merged
Conversation
Lightning00Blade
force-pushed
the
move-deps-around
branch
from
September 21, 2026 17:53
5c7a447 to
d5b4daf
Compare
Lightning00Blade
force-pushed
the
move-deps-around
branch
4 times, most recently
from
September 28, 2026 08:33
be04f2b to
abf3135
Compare
Lightning00Blade
added this pull request to stack #2851
September 28, 2026 08:33
Lightning00Blade
force-pushed
the
move-deps-around
branch
from
September 28, 2026 09:07
abf3135 to
1ed9b1b
Compare
Lightning00Blade
force-pushed
the
move-deps-around
branch
2 times, most recently
from
September 28, 2026 13:29
305f86e to
04d56ea
Compare
Lightning00Blade
marked this pull request as ready for review
September 28, 2026 13:30
OrKoN
requested changes
Sep 28, 2026
OrKoN
left a comment
Collaborator
There was a problem hiding this comment.
Please check the following:
- In
src/config/mcp-options.ts(getMcpOptionsForViaCliandparser), apply the--viaClidefault forcategoryExtensionsin.middleware()when!args.autoConnect && !args.browserUrl && !args.wsEndpoint(matchingisolated) and updatedefaultDescriptiononisolatedingetMcpOptionsForViaCli(). Keepingdefault: trueoncategoryExtensionsingetMcpOptionsForViaCli()causes.check()to throw a mutual-exclusivity error whenever--viaCli(chrome-devtools start) is used with--browserUrl,--wsEndpoint, or--auto-connect, and spreading...mcpOptions.isolatedleaksdefaultDescription: 'false'into CLI help. - In
src/config/browser-options.ts,src/config/mcp-options.ts(parsermiddleware), andsrc/telemetry/flagUtils.ts(computeFlagUsage), ensureisolatedandchanneldefaults are recognized bycomputeFlagUsageand do not setargs.channel = 'stable'whenbrowserUrl,wsEndpoint, orexecutablePathis provided. BecausebrowserOptions.isolatedandbrowserOptions.channelonly setdefaultDescription(!('default' in config)), unconditionally settingargs.isolated = falseandargs.channel = 'stable'in middleware causescomputeFlagUsageto logisolated_present: trueon every run andchannel_present: true/channel: 'CHANNEL_STABLE'even when connecting viabrowserUrl/wsEndpointor launching viaexecutablePath. - In
src/config/mcp-options.ts(parsermiddleware) andsrc/ToolHandler.ts, resolve the legacyexperimentalToonFormatfallback inToolHandler(or before applying the'default'default) instead of checkingargs.experimentalDataFormat === 'default'in middleware. Checkingargs.experimentalDataFormat === 'default'after Yargs appliesdefault: 'default'causes--experimentalToonFormatto override an explicit--experimentalDataFormat=defaultand causescomputeFlagUsageto reportexperimental_data_format_present: truewhen only--experimentalToonFormatwas passed.
Lightning00Blade
force-pushed
the
move-deps-around
branch
2 times, most recently
from
September 28, 2026 15:09
2dfb780 to
7a68a30
Compare
Lightning00Blade
force-pushed
the
move-deps-around
branch
from
September 28, 2026 15:57
7a68a30 to
9e413c2
Compare
OrKoN
self-requested a review
September 29, 2026 06:15
OrKoN
approved these changes
Sep 29, 2026
paviad
added a commit
to paviad/chrome-devtools-mcp
that referenced
this pull request
Oct 9, 2026
Remove the categoryExtensions conflicts with autoConnect, browserUrl and wsEndpoint added in ChromeDevTools#2753. Chrome 149+ supports extension debugging over these connections, and 1.10.1 accepts the combination. Update the --categoryExtensions help text, generated docs and the troubleshooting skill to state the Chrome 149+ requirement for attach modes. Fixes ChromeDevTools#2989
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extracts the conflicting config argument to a separate check, to allow both defaults and conflict on the same option.