Repository navigation
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
JayeeHsu
force-pushed
the
feat/set-extra-http-headers
branch
from
March 20, 2026 03:36
28ae38f to
4c3697a
Compare
Author
|
I have signed the CLA. |
Add a new MCP tool that allows setting extra HTTP headers on all page requests via Puppeteer's page.setExtraHTTPHeaders(). Headers persist across navigations and can be cleared by passing an empty object. This addresses the need for injecting custom headers (e.g. swim-lane routing, A/B testing, feature flags) on all request types including initial document loads, which is not possible with initScript alone. Closes ChromeDevTools#1175
JayeeHsu
force-pushed
the
feat/set-extra-http-headers
branch
from
March 20, 2026 06:34
f86f6e5 to
372fe5c
Compare
Author
|
@wolfib Could you help review this? |
OrKoN
requested changes
Apr 1, 2026
OrKoN
left a comment
OrKoN
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the PR! Please align the implementation with the comment in #1175 (comment) To also work better with the CLI interface, perhaps we can have a string format for expressing headers.
Collaborator
|
Closing in favour of earlier #1176 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set_extra_http_headersthat allows setting extra HTTP headers on all page requests via Puppeteer'spage.setExtraHTTPHeaders()Closes #1175
Test plan
🤖 Generated with Claude Code