Repository navigation
fix(demo): share React upload landing styles across five demos - #354
Merged
ChristopherVR merged 2 commits intoSep 29, 2026
Merged
Conversation
Use the React demo's upload landing as the visual baseline for Vue, Angular, Vanilla, and Svelte. Replace duplicated demo CSS with one stylesheet and keep file picker and blank-deck actions in each binding. Pin the common card and button metrics in the framework-neutral e2e spec. Refs ChristopherVR#342 Co-Authored-By: Codex <codex@openai.com>
Match the Angular demo's TypeScript resolution to its Vite alias for the built viewer package. Include Vite environment types, declare the CSS subpath, and add the demo to the workspace typecheck command. Co-Authored-By: Codex <codex@openai.com>
github-actions
Bot
added
react
12 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Consolidate the five demo upload landing screens into
demos/shared/dropzone.css, using the React demo at port 4173 as the visual reference. Each binding keeps its existing file picker and new-presentation behavior. This is a scoped demo landing-page step related to #342.Also make the Angular demo's standalone TypeScript check resolve the same built viewer declarations used by Vite, load Vite environment types, and participate in the workspace
typecheckcommand.Type of change
Cross-binding parity
UI fix
Testing
e2e/dropzone-browse.spec.ts.bun run e2erun locally. Its standard configuration starts dev servers and a collaboration relay; I used the five already-running demo pages for this visual check and did not start services.On the existing React, Vue, Angular, Svelte, and Vanilla pages, the card measured 900 x 198 px and both buttons measured 38 px high with 6 px corners. The text sizes, padding, gaps, and theme colors also matched.
Checks run locally
bun run lintbun run fmt:checkbun run typecheckbun run e2e:contractbun run test(not run; this change has no package runtime logic)Conventional Commits