Skip to content

fix(ui): align File backstage navigation across five bindings - #351

Merged
ChristopherVR merged 1 commit into
ChristopherVR:mainfrom
yunfeizhu:fix/backstage-nav-spacing-347-pr
Sep 23, 2026
Merged

ChristopherVR merged 1 commit into
ChristopherVR:mainfrom
yunfeizhu:fix/backstage-nav-spacing-347-pr

Conversation

@yunfeizhu

Copy link
Copy Markdown
Contributor

Summary

  • Align the File backstage navigation rows, icons, active and hover states, and keyboard focus treatment across React, Vue, Angular, Svelte, and Vanilla.
  • Make the desktop back control 40px high and clickable across the full sidebar width, with a centered arrow. Keep a 48px control on narrow screens and allow the desktop navigation to scroll when the window is short.
  • Share the Tailwind navigation class definitions used by React and Vue, while keeping the other bindings' rendering framework-native.

This branch is based on main; the search-field changes in #350 are outside this diff.

Verification

  • e2e/backstage-nav-spacing.spec.ts: 15 passed across the five demos on this branch.
  • Type checks passed for all five bindings (Svelte reported 0 errors and 5 warnings in unrelated files).
  • Formatting, lint, E2E neutrality, and targeted dependency/Angular builds passed.

Closes #347.

@github-actions github-actions Bot added react React binding (pptx-react-viewer) vue Vue binding (pptx-vue-viewer) angular Angular binding (pptx-angular-viewer) svelte Svelte binding (pptx-svelte-viewer) vanilla Vanilla binding (pptx-vanilla-viewer) shared Framework-agnostic viewer logic (pptx-viewer-shared) e2e Playwright end-to-end suite labels Sep 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Cross-binding parity check

This is advisory only and does not block the PR. It looks at changed file paths, so it cannot tell a genuinely framework-specific change from a parity gap. If it is wrong here, just say so in a comment.

Binding This PR
React changed
Vue changed
Angular changed
Svelte changed
Vanilla changed

Some changed bindings have no test changes

No test files changed under: React, Vue, Angular, Svelte, Vanilla.


See the parity rule for what is expected. Missing: none.

@ChristopherVR

Copy link
Copy Markdown
Owner

@ a few conflicts to resolve @yunfeizhu

@yunfeizhu
yunfeizhu force-pushed the fix/backstage-nav-spacing-347-pr branch from d1d8f07 to c16aa3b Compare September 23, 2026 11:15
@ChristopherVR
ChristopherVR merged commit 2196a0e into ChristopherVR:main Sep 23, 2026
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

angular Angular binding (pptx-angular-viewer) e2e Playwright end-to-end suite react React binding (pptx-react-viewer) shared Framework-agnostic viewer logic (pptx-viewer-shared) svelte Svelte binding (pptx-svelte-viewer) vanilla Vanilla binding (pptx-vanilla-viewer) vue Vue binding (pptx-vue-viewer)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align File backstage navigation spacing across the five bindings

2 participants