Repository navigation
fix(pptx): follow slide links outside slide shows - #38
Merged
Merged
Conversation
github-actions
Bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal text-run and shape slide links now navigate inside normal and read-only viewers. Text-run links also use the slide-show action runner instead of opening
slideN.xml. All five PPTX bindings expose a cancellable host callback and hide read-only authoring badges. Editing keeps Ctrl/Cmd+Click navigation.Fixes #37.
Validation: the reporter's deck and 110 local browser cases passed across all five bindings; builds, typechecks and clean-install package checks passed.
Full fork CI completed: PPTX build/checks and 50/51 browser jobs passed, including all 35 new slide-link regressions. React's two table-markup failures reproduce on unmodified upstream. Other failures are formatting in unchanged Visio documentation and a Svelte collaboration pixel-delta assertion: its trace shows identical synchronized geometry while the peer's zoom changes. The collaboration case passes locally on both upstream and this commit.