This repository has been archived by the owner on Aug 26, 2024. It is now read-only.
Fixed RAAN and added Petropoulos test cases #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I should be able to keep the rest of the OEs free, but this is not happening!
Had to update the signation to NewOptimalΔOrbit. TestMultiCorrectOE leads to a panic. I suspect it's due to the eccentricity correction, but I'm not sure yet. If not, it's due to the Ruggerio factor. Note: the inclination change does not work at all with the provided equation, regardless of the duration of propagation (I tried a 20 times longer propagation).
Also ensured that the angle conversaions always lead to positive angles.
WEIRD: norm(R) is different from GetRNorm() in the Vallado test case, but it works perfectly fine (within some numerical approximation of ~4km) in the astrocro propagation.
Also tried to improve the test coverage, but kinda failed. I don't know why the code in the spacecraft part for dropping the cargo does not execute. That's a big question mark but not important right now. First I gotta solve those damn orbital corrections.
But they all either fail or panic.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8.