Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove duplicate cargo check workflow #112

Merged
merged 1 commit into from
Jul 31, 2024
Merged

chore: Remove duplicate cargo check workflow #112

merged 1 commit into from
Jul 31, 2024

Conversation

lj3954
Copy link
Contributor

@lj3954 lj3954 commented Jul 31, 2024

Pull Request

Title

Remove cargo check workflow

Type of Change

  • Refactoring

Description

cargo clippy runs an instance of cargo check by default (https://github.com/rust-lang/rust-clippy/blob/master/src/main.rs#L62). There is no need for an extra workflow to run cargo check on the side. Issues which cargo check will flag will also be caught by clippy.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • My changes generate no errors/warnings/merge conflicts.

@ChrisTitusTech ChrisTitusTech merged commit 24bf550 into ChrisTitusTech:main Jul 31, 2024
1 check passed
@lj3954 lj3954 deleted the remove_unnecessary_check branch July 31, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisTitusTech ChrisTitusTech ChrisTitusTech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lj3954 @ChrisTitusTech