Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Build aarch64 binaries #101

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

lj3954
Copy link
Contributor

@lj3954 lj3954 commented Jul 30, 2024

Pull Request

Title

Build aarch64 binaries

Type of Change

  • New feature

Description

Build aarch64 binaries using cross-rs, which allows for automated cross compilation using docker images. Update start.sh and startdev.sh to link to them.

Testing

I locally tested the build command, along with the start scripts to ensure they reach the correct URLs.

Additional Information

Note that releases without aarch64 binaries will throw an error on download for users on aarch64 systems, but they aren't able to launch the current x86_64 binaries regardless.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • My changes generate no errors/warnings/merge conflicts.

@lj3954
Copy link
Contributor Author

lj3954 commented Jul 30, 2024

Changes are only in CI and the start scripts. No error from cargo check is related to this PR.

@ChrisTitusTech ChrisTitusTech merged commit 938ce3f into ChrisTitusTech:main Jul 31, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants