Repository navigation
ci(semgrep): install the hash-pinned tree with --no-deps (1/2 for PyJWT/urllib3 alerts) - #400
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
0 open findings
What changed in this PR
Updates the Semgrep GitHub Actions workflow to install the hash-pinned Semgrep dependency tree without invoking pip’s dependency resolver, enabling follow-on dependency pin overrides for the PyJWT/urllib3 alert remediation.
Changes:
- Add
--no-depsto thepip install --require-hashesstep for Semgrep. - Document why
--no-depsis required and how it interacts with the pinned transitive tree / overrides.
| File | Description |
|---|---|
| .github/workflows/semgrep.yaml | Installs Semgrep requirements with --no-deps to avoid resolver re-applying upstream pins while still enforcing hash checking. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Copilot stopped reviewing on behalf of
Chris-Wolfgang due to an error
October 10, 2026 23:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1 of 2 for the PyJWT / urllib3 alerts on
.github/requirements/semgrep.txt. Merge this first, then its 2/2 PR.Change (protected-only:
.github/workflows/semgrep.yaml)pip install --no-deps --require-hashes -r .github/requirements/semgrep.txt.semgrep.txtis a complete, hash-pinned dependency tree, so pip's resolver has nothing to add; it can only re-apply semgrep's own pins. The 2/2 PR overrides one of them: semgrep 1.177.0 and 1.178.0 (the latest) both pinpyjwt[crypto]~=2.13.0, and every PyJWT ≤ 2.14.0 is affected by 12 advisories (1 critical). Without--no-deps, pip refuses that tree.Why it's safe to merge first
The current
semgrep.txtis also a complete tree, so--no-depsinstalls exactly the same packages from it. This PR's own Semgrep run shows it: the workflow installs the base branch's requirements file.Evidence
Proven on Chris-Wolfgang/DbContextBuilder, where the identical change (Chris-Wolfgang/DbContextBuilder#477, then #479) has run green on
main.🤖 Generated with Claude Code