Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Config_Flow. No Docker! No local Python-Scripts! #67

Merged
merged 12 commits into from
Feb 24, 2023
Merged

Added Config_Flow. No Docker! No local Python-Scripts! #67

merged 12 commits into from
Feb 24, 2023

Conversation

mricharz
Copy link

Hi

I changed ... uhm... yes. everything so far...

First of all: Thanks for your integration!

This was a great basis for further development.

Now i am a friend of KISS (Keep it simple and stupid) and a docker-container and the execution of local python code is NOT simple and stupid \o/

so, i refactored everything to work with a config_flow:

  • no manual configuration
  • no docker container
  • no local python scripts
  • no pain!

also i added translations.

Please feel free to test it, change it, give feedback and/or merge it.

best regards

Manuel Richarz

@mricharz
feat: add config_flow
d061b21 
feat: add coordinator for polling data
feat: add translation
feat: no need for local python script
feat: no need docker-container
feat: no manual configuration
refactor: ... hm ... everything?
@mricharz
Merge branch 'main' of github.com:Chouffy/home_assistant_tgtg into merge
e5e9bf7 
# Conflicts:
#	README.md
#	custom_components/tgtg/manifest.json
#	custom_components/tgtg/sensor.py
#	tgtg_get_favorites_item_id.py
#	tgtg_get_tokens.py
@mricharz
fix: remove obsolete and not working options flow
3489db8
@mricharz
Merge pull request #1 from mricharz/merge
153cb21 
Merge
@tjorim tjorim added the enhancement New feature or request label Feb 23, 2023
@tjorim
Copy link
Collaborator

tjorim commented Feb 23, 2023 •
edited
Loading

Wow, great job! I'll make sure to test it.

A few questions tho:

  • does it import existing configurations? Or does it require a new set up?
  • is yaml-based config still supported?

I know most core integration have a transition period. Migrating from yaml-based to UI imports existing setup, and can he safely deleted from configuration.yaml afterwards.

PS: can we get rid of v2 and just make this available under the same domain and name?

@mricharz
Copy link
Author

  • it requires a new setup
  • it does not support yaml based config.

As i said: KISS :-)
Easy to use for everyone. Just mark your favourites in TGTG-App and they will appear as sensor in HA.

@mricharz
Copy link
Author

You can also setup multiple accounts

mricharz and others added 8 commits February 23, 2023 16:02
@mricharz
chore: remove V2 from naming
5c08bab
@mricharz
Merge pull request #2 from mricharz/merge
53cbff3 
chore: remove V2 from naming
@mricharz
chore: decrease log level of some outputs
3861457 
chore: remove default email in config_flow
@mricharz
Merge pull request #3 from mricharz/merge
14bd819 
chore: decrease log level of some outputs
@tjorim
Sort manifest.json
36f6297
@mricharz
fix: remove title from translations because its a brand name and does…
16cec82 
… not need to be translated
@mricharz
Merge pull request #4 from mricharz/merge
e64c153 
fix: remove title from translations because its a brand name and does…
@tjorim
Remove title string
dfbdc39
@tjorim tjorim changed the base branch from main to config_flow February 24, 2023 00:29
@tjorim
Copy link
Collaborator

tjorim commented Feb 24, 2023

Looks good to me, I'll merge it in a separate branch for now.
Thanks again for your hard work!

@tjorim tjorim merged commit fca49e9 into Chouffy:config_flow Feb 24, 2023
@tjorim tjorim added this to the 6.0.0 Rewrite with config_flow milestone Feb 24, 2023
@tjorim tjorim linked an issue Feb 24, 2023 that may be closed by this pull request
[Need Help] Use Home Assistant UI to set-up TGTG integration and import tokens #3
Closed
@tjorim tjorim mentioned this pull request Feb 24, 2023
Closed
@mricharz
Copy link
Author

The reason i renamed the integration to tgtg_v2 was for running both integrations parallel.
I could keep the old integration and also setup the new one.
maybe this is still the best solution for migration from old to new setup. we don't have that many users as other integrations in HA. so i would not worry to much about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
6.0.0 Rewrite with config_flow
Development

Successfully merging this pull request may close these issues.

[Need Help] Use Home Assistant UI to set-up TGTG integration and import tokens
2 participants
@mricharz @tjorim