Restructure client functions in library #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the upcoming listener, we can use the same snapshot functions instead of rewriting them.
ruuda
approved these changes
Jan 14, 2022
|
Ah Clippy is unhappy though, can you fix that? |
enriquefynn
force-pushed
the
listener-client
branch
from
2849e53 to
8ddede2
Compare
Makes clippy happy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the upcoming listener, we can use the same snapshot functions
instead of rewriting them.
The listener features will be added on top of this PR. Let's not merge it until all features are done