-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[STACKED] Command to generate presigned exit message #55
Conversation
### Command to send SignedBLSToExecutionChange request to Beacon node | ||
|
||
``` | ||
curl -H "Content-Type: application/json" -d '{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we showing curl command instead of cli cmd?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The command right now does not support sending output to beacon node; it should be easy to add though given openssl-sys
is already a dependency. I will do it in #54 as this PR only touches presigned exit message, but bls-to-execution-change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sending to beacon node was implemented in 64ef067
README.md
Outdated
./target/debug/eth-staking-smith presigned-exit-message --chain mainnet --mnemonic "entire habit bottom mention spoil clown finger wheat motion fox axis mechanic country make garment bar blind stadium sugar water scissors canyon often ketchup" --validator_start_index 0 --validator_index 100 --epoch 300000 | ||
``` | ||
|
||
Note that --validator-index and --validator-start-index are two distinct parameter, the former being index of validator on Beacon chain, and the latter is the index of validator private key derived from the seed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm can we not just rename them to make it more explicit? --validator-beacon-index
or --validator_seed_index
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, renamed in 176cfba, will rename in bls-to-execution-change in nested PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! i would consider renaming arguments to make them easily understandable as mentioned in the comments
…t-message (#54) * Make bls-to-execution-change command work * [STACKED] Command to generate presigned exit message (#55) * Command to generate presigned exit message * Docs for presigned-exit-message * Code review feedback * Add support for sending signed payloads to beacon node * Add note on backwards compatibility policy * Unify regex usage * Adjustments for single payload cmds - Fix presigned-exit-message format & beacon node sending - Rename Operator traits -> validator - Rename operator module -> operations * Fix README
Based on cleanup/refactor introduced in #54, create command to generate presigned exit message based on existing mnemonic