Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

substrate: fix nomination to a single validator #8

Merged
merged 2 commits into from
Aug 21, 2024
Merged

substrate: fix nomination to a single validator #8

merged 2 commits into from
Aug 21, 2024

Conversation

mkaczanowski
Copy link
Contributor

@mkaczanowski mkaczanowski commented Aug 21, 2024 •
edited
Loading

The problem occurs when a single validator is being passed in the Array and ...params resolves it to single string which polkadot api doesn't expect

Tested with:

npm run staking-cli -- substrate tx delegate 0.1
npm run staking-cli -- substrate tx nominate 0.1
npm run staking-cli -- substrate tx bond-extra 0.1
npm run staking-cli -- substrate tx unbond 0.1
npm run staking-cli -- substrate tx withdraw

@mkaczanowski mkaczanowski marked this pull request as ready for review August 21, 2024 12:53
welldan97
welldan97 approved these changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@welldan97 welldan97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@welldan97 welldan97 merged commit e21c2dc into main Aug 21, 2024
1 check passed
@welldan97 welldan97 deleted the fix_substrate_nominate_transaction_to_a_single_validator branch August 21, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@welldan97 welldan97 welldan97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkaczanowski @welldan97