Allow enabling channel sync through UI (#754)

client/src/app/+admin/config/edit-custom-config/edit-basic-configuration.component.html

@@ -267,10 +267,10 @@
               inputName="importVideosHttpEnabled" formControlName="enabled"
               i18n-labelText labelText="Allow import with HTTP URL (e.g. YouTube)"
             >
-            <ng-container ngProjectAs="description">
-              <span i18n>⚠️ If enabled, we recommend to use <a class="link-orange" href="https://docs.joinpeertube.org/maintain-configuration?id=security">a HTTP proxy</a> to prevent private URL access from your PeerTube server</span>
-            </ng-container>
-          </my-peertube-checkbox>
+              <ng-container ngProjectAs="description">
+                <span i18n>⚠️ If enabled, we recommend to use <a class="link-orange" href="https://docs.joinpeertube.org/maintain-configuration?id=security">a HTTP proxy</a> to prevent private URL access from your PeerTube server</span>
+              </ng-container>
+            </my-peertube-checkbox>
           </div>
 
           <div class="form-group" formGroupName="torrent">
@@ -285,6 +285,22 @@
           </div>
 
         </ng-container>
+
+        <ng-container formGroupName="synchronization">
+          <div class="form-group">
+            <my-peertube-checkbox
+              inputName="importSynchronizationEnabled" formControlName="enabled"
+              i18n-labelText labelText="Allow channel synchronization with channel of other platforms like YouTube (requires allowing import with HTTP URL)"
+            >
+            <ng-container ngProjectAs="description">
+              <span i18n [hidden]="isImportVideosHttpEnabled()">
+                  ⛔ You need to allow  import with HTTP URL to be able to activate this feature.
+              </span>
+            </ng-container>
+            </my-peertube-checkbox>
+          </div>
+        </ng-container>
+
       </ng-container>
 
       <ng-container formGroupName="autoBlacklist">

client/src/app/+admin/config/edit-custom-config/edit-basic-configuration.component.ts

@@ -30,6 +30,7 @@ export class EditBasicConfigurationComponent implements OnInit, OnChanges {
   ngOnInit () {
     this.buildLandingPageOptions()
     this.checkSignupField()
+    this.checkImportSyncField()
 
     this.availableThemes = this.themeService.buildAvailableThemes()
   }
@@ -67,6 +68,14 @@ export class EditBasicConfigurationComponent implements OnInit, OnChanges {
     return { 'disabled-checkbox-extra': !this.isSignupEnabled() }
   }
 
+  isImportVideosHttpEnabled (): boolean {
+    return this.form.value['import']['videos']['http']['enabled'] === true
+  }
+
+  importSynchronizationChecked () {
+    return this.isImportVideosHttpEnabled() && this.form.value['import']['synchronization']['enabled']
+  }
+
   hasUnlimitedSignup () {
     return this.form.value['signup']['limit'] === -1
   }
@@ -97,6 +106,21 @@ export class EditBasicConfigurationComponent implements OnInit, OnChanges {
     return this.themeService.getDefaultThemeLabel()
   }
 
+  private checkImportSyncField () {
+    const importSyncControl = this.form.get('import.synchronization.enabled')
+    const importVideosHttpControl = this.form.get('import.videos.http.enabled')
+
+    importVideosHttpControl.valueChanges
+      .subscribe((httpImportEnabled) => {
+        importSyncControl.setValue(httpImportEnabled && importSyncControl.value)
+        if (httpImportEnabled) {
+          importSyncControl.enable()
+        } else {
+          importSyncControl.disable()
+        }
+      })
+  }
+
   private checkSignupField () {
     const signupControl = this.form.get('signup.enabled')
 

client/src/app/+admin/config/edit-custom-config/edit-custom-config.component.ts

@@ -144,6 +144,9 @@ export class EditCustomConfigComponent extends FormReactive implements OnInit {
           torrent: {
             enabled: null
           }
+        },
+        synchronization: {
+          enabled: null
         }
       },
       trending: {

client/src/app/shared/shared-instance/instance-features-table.component.html

@@ -106,6 +106,13 @@
       </td>
     </tr>
 
+    <tr>
+      <th i18n class="sub-label" scope="row">Channel synchronization with other platforms (YouTube, Vimeo, ...)</th>
+      <td>
+        <my-feature-boolean [value]="serverConfig.import.synchronization.enabled"></my-feature-boolean>
+      </td>
+    </tr>
+
     <tr>
       <th i18n class="label" colspan="2">Search</th>
     </tr>

config/default.yaml

@@ -369,7 +369,6 @@ user:
 
 video_channels:
   max_per_user: 20 # Allows each user to create up to 20 video channels.
-  synchronization_interval: 15 minutes
 
 # If enabled, the video will be transcoded to mp4 (x264) with `faststart` flag
 # In addition, if some resolutions are enabled the mp4 video file will be transcoded to these new resolutions
@@ -540,6 +539,9 @@ import:
       # We recommend to only enable magnet URI/torrent import if you trust your users
       # See https://docs.joinpeertube.org/maintain-configuration?id=security for more information
       enabled: false
+  synchronization:
+    enabled: false
+    check_interval: 1 hour
 
 auto_blacklist:
   # New videos automatically blacklisted so moderators can review before publishing

server/controllers/api/config.ts

@@ -271,6 +271,9 @@ function customConfig (): CustomConfig {
         torrent: {
           enabled: CONFIG.IMPORT.VIDEOS.TORRENT.ENABLED
         }
+      },
+      synchronization: {
+        enabled: CONFIG.IMPORT.SYNCHRONIZATION.ENABLED
       }
     },
     trending: {

server/initializers/checker-after-init.ts

@@ -48,6 +48,7 @@ function checkConfig () {
   checkRemoteRedundancyConfig()
   checkStorageConfig()
   checkTranscodingConfig()
+  checkImportConfig()
   checkBroadcastMessageConfig()
   checkSearchConfig()
   checkLiveConfig()
@@ -198,6 +199,18 @@ function checkTranscodingConfig () {
       throw new Error('Video import concurrency should be > 0')
     }
   }
+
+  if (CONFIG.IMPORT.VIDEOS.HTTP.ENABLED || CONFIG.IMPORT.VIDEOS.TORRENT.ENABLED) {
+    if (CONFIG.IMPORT.VIDEOS.CONCURRENCY <= 0) {
+      throw new Error('Video import concurrency should be > 0')
+    }
+  }
+}
+
+function checkImportConfig () {
+  if (CONFIG.IMPORT.SYNCHRONIZATION.ENABLED && !CONFIG.IMPORT.VIDEOS.HTTP) {
+    throw new Error("You need to enable HTTP import to allow synchronization")
+  }
 }
 
 function checkBroadcastMessageConfig () {

server/initializers/config.ts

@@ -300,8 +300,7 @@ const CONFIG = {
     get VIDEO_QUOTA_DAILY () { return parseBytes(config.get<number>('user.video_quota_daily')) }
   },
   VIDEO_CHANNELS: {
-    get MAX_PER_USER () { return config.get<number>('video_channels.max_per_user') },
-    get SYNCHRONIZATION_INTERVAL () { return parseDurationToMs(config.get<string>('video_channels.synchronization_interval')) }
+    get MAX_PER_USER () { return config.get<number>('video_channels.max_per_user') }
   },
   TRANSCODING: {
     get ENABLED () { return config.get<boolean>('transcoding.enabled') },
@@ -396,6 +395,10 @@ const CONFIG = {
       TORRENT: {
         get ENABLED () { return config.get<boolean>('import.videos.torrent.enabled') }
       }
+    },
+    SYNCHRONIZATION: {
+      get ENABLED () { return config.get<boolean>('import.synchronization.enabled') },
+      get CHECK_INTERVAL () { return parseDurationToMs(config.get<string>('import.synchronization.check_interval')) }
     }
   },
   AUTO_BLACKLIST: {
@@ -497,6 +500,7 @@ const CONFIG = {
       get IS_DEFAULT_SEARCH () { return config.get<boolean>('search.search_index.is_default_search') }
     }
   }
+
 }
 
 function registerConfigChangedHandler (fun: Function) {

server/lib/server-config-manager.ts

@@ -170,6 +170,9 @@ class ServerConfigManager {
           torrent: {
             enabled: CONFIG.IMPORT.VIDEOS.TORRENT.ENABLED
           }
+        },
+        synchronization: {
+          enabled: CONFIG.IMPORT.SYNCHRONIZATION.ENABLED
         }
       },
       autoBlacklist: {

server/middlewares/validators/config.ts

@@ -63,6 +63,8 @@ const customConfigUpdateValidator = [
   body('import.videos.http.enabled').isBoolean().withMessage('Should have a valid import video http enabled boolean'),
   body('import.videos.torrent.enabled').isBoolean().withMessage('Should have a valid import video torrent enabled boolean'),
 
+  body('import.synchronization.enabled').isBoolean().withMessage('Should have a valid synchronization enabled boolean'),
+
   body('trending.videos.algorithms.default').exists().withMessage('Should have a valid default trending algorithm'),
   body('trending.videos.algorithms.enabled').exists().withMessage('Should have a valid array of enabled trending algorithms'),
 
@@ -105,6 +107,7 @@ const customConfigUpdateValidator = [
     if (areValidationErrors(req, res)) return
     if (!checkInvalidConfigIfEmailDisabled(req.body, res)) return
     if (!checkInvalidTranscodingConfig(req.body, res)) return
+    if (!checkInvalidSynchronizationConfig(req.body, res)) return
     if (!checkInvalidLiveConfig(req.body, res)) return
     if (!checkInvalidVideoStudioConfig(req.body, res)) return
 
@@ -152,6 +155,14 @@ function checkInvalidTranscodingConfig (customConfig: CustomConfig, res: express
   return true
 }
 
+function checkInvalidSynchronizationConfig (customConfig: CustomConfig, res: express.Response) {
+  if (customConfig.import.synchronization.enabled && !customConfig.import.videos.http.enabled) {
+    res.fail({ message: 'You need to enable HTTP video import in order to enable channel synchronization' })
+    return false
+  }
+  return true
+}
+
 function checkInvalidLiveConfig (customConfig: CustomConfig, res: express.Response) {
   if (customConfig.live.enabled === false) return true
 

server/tests/api/check-params/config.ts

@@ -160,6 +160,9 @@ describe('Test config API validators', function () {
         torrent: {
           enabled: false
         }
+      },
+      synchronization: {
+        enabled: false
       }
     },
     trending: {

server/tests/api/server/config.ts

@@ -362,6 +362,9 @@ const newCustomConfig: CustomConfig = {
       torrent: {
         enabled: false
       }
+    },
+    synchronization: {
+      enabled: false
     }
   },
   trending: {

shared/models/server/custom-config.model.ts

@@ -162,6 +162,9 @@ export interface CustomConfig {
         enabled: boolean
       }
     }
+    synchronization: {
+      enabled: boolean
+    }
   }
 
   trending: {

shared/models/server/server-config.model.ts

@@ -188,6 +188,9 @@ export interface ServerConfig {
         enabled: boolean
       }
     }
+    synchronization: {
+      enabled: boolean
+    }
   }
 
   autoBlacklist: {

shared/server-commands/server/config-command.ts

@@ -354,6 +354,9 @@ export class ConfigCommand extends AbstractCommand {
           torrent: {
             enabled: false
           }
+        },
+        synchronization: {
+          enabled: false
         }
       },
       trending: {

support/doc/api/openapi.yaml

@@ -6582,6 +6582,11 @@ components:
                   properties:
                     enabled:
                       type: boolean
+            synchronization:
+              type: object
+              properties:
+                enabled:
+                  type: boolean
         autoBlacklist:
           type: object
           properties:
@@ -6946,6 +6951,11 @@ components:
                   properties:
                     enabled:
                       type: boolean
+            synchronization:
+              type: object
+              properties:
+                enabled:
+                  type: boolean
         autoBlacklist:
           type: object
           properties: