Custom error view upon 401 API response #5097
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It means you have to replace NODE_ENV=test to NODE_ENV=dev if you use it npm run dev:* commands are already updated
It has more activity and they fix bugs more quickly
Chocobozzz
force-pushed
the
feat-4768-not-auth
branch
from
bc748d4 to
be2df48
Compare
|
Thanks, it's much more better! (merged manually) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Show a message telling the user is not authorized to see a resource when 401 is responded from the API, instead of redirect to /login. I decided to not redirect to login and show a message since this is more clear for the user, and it's an uncommon case where an extra click won't harm.
Related issues
closes #4768
Has this been tested?
Screenshots