Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "zxx" (no linguistic content) in available video languages #4631

Merged
merged 4 commits into from
Dec 13, 2021

Conversation

Poslovitch
Copy link
Contributor

@Poslovitch Poslovitch commented Dec 12, 2021

Description

It adds zxx as part of the available "language codes" in the backend. zxx is the ISO-639 code for the absence of linguistic content, according to Wikipedia (https://en.wikipedia.org/wiki/ISO_639):

No linguistic information at all (added 2006-01-11). The content (e.g. graphics, photos or audio/video records not including text in a human language, or technical metadata and most programming source code) is usable as is with any language and should not be translated (except for its description possibly associated in separate contents, or for non-essential fragments of the content).

As this "language" also appeared in the group "All languages" in the forms, I had to create a dedicated group for it. Feel free to suggest better names 😉.

Related issues

Closes #1489

Has this been tested?

  • 👍 yes, I added tests to the test suite
  • 💭 no, because this PR is a draft and still needs work
  • 🙅 no, because this PR does not update server code
  • 🙋 no, because I need help

Screenshots

In the video-edit form:

image

image

When watching the video :
image

@Chocobozzz Chocobozzz merged commit 81547ac into Chocobozzz:develop Dec 13, 2021
@Chocobozzz
Copy link
Owner

Thanks!

@Poslovitch
Copy link
Contributor Author

Well, thanks for merging ! ❤️

@Poslovitch Poslovitch deleted the feature/1489/no-language branch December 17, 2021 23:20
@ghost
Copy link

ghost commented Apr 16, 2022

This is a harmful feature imo. The selected language should or could also reflect the language of the title of the video. Using "no linguistic content" would only make it even harder to filter out content in languages you do not understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option for language: "This video has no language"
2 participants