add loop toggle to the player contextmenu #3949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chocobozzz
reviewed
Apr 12, 2021
| @@ -121,7 +121,7 @@ | |||
| "tslint-config-standard": "^9.0.0", | |||
| "typescript": "~4.1.3", | |||
| "video.js": "^7", | |||
| "videojs-contextmenu-ui": "^5.0.0", | |||
| "videojs-contextmenu-pt": "^5.4.1", | |||
There was a problem hiding this comment.
Did you try to make a PR on the origin repository?
There was a problem hiding this comment.
@Chocobozzz I opened a PR on brightcove's repository
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces the current
videojs-contextmenu-uiwith an owned and modified version that allows evaluating the value of the context menucontentatoncontextmenuevent, allowing dynamic context menus in the player.side note: having our own version of this videojs plugin will come in handy for future work in the contextmenu, for instance adding support for icons.
Related issues
closes #3802
Has this been tested?
Open any video and toggle the loop feature.
Screenshots