consider all possible block state instead of only default block state model for render type setting #188
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the origin logic for setting render type is this
the problem is that it only considers the default block state's model.
for example, the redstone ore's default block state is
LIT:false.if I only set the
LIT:truemodel and need it to use layer/rendertype cutoutthe Predicate produce function will just return null as the
LIT:falsemodel is not any instance belowthe layer/rendertype setting in
LIT:falsemodel is ignoredso , just use
block.getStateDefinition().getPossibleStates()andPredicate#orto consider all models' settingthe problem is that if a block has many states, this may become a performance issue.
though forge add
canRenderInLayerto replacegetRenderLayerto allow one block to have multi rendertypescurrent implementation just convert parameter from blockstae -> state
the map which stores the information is also
Map<IRegistryDelegate<Block>, Predicate<RenderType>>though we can just cache
solid, cutout_mipped, cutout, translucent, tripwirebut it is not good for rendertype usage like MinecraftForge/MinecraftForge#8331