Repository navigation
Reference System.Net.ServerSentEvents only on net8.0/net9.0 - #9941
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a restore/AOT publish failure by only referencing System.Net.ServerSentEvents when targeting frameworks that need the standalone package (net8.0/net9.0), avoiding NU1510 on net10.0 where the API is in-box.
Changes:
- Gate
System.Net.ServerSentEventsPackageReferencetonet8.0andnet9.0inFusion.Execution. - Gate
System.Net.ServerSentEventsPackageReferencetonet8.0andnet9.0inTransport.Http.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/HotChocolate/Fusion/src/Fusion.Execution/HotChocolate.Fusion.Execution.csproj | Adds TFM-conditional package reference so net10.0 avoids NU1510 while net8.0/net9.0 still restore the package. |
| src/HotChocolate/AspNetCore/src/Transport.Http/HotChocolate.Transport.Http.csproj | Same TFM-conditional package reference to keep SSE support on net8.0/net9.0 without pulling the package on net10.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Code Coverage OverviewLanguages: C# C# / code-coverage/dotnetThe overall coverage in the Show a code coverage summary of the most impacted files.
Code Coverage is in Public Preview. Learn more and provide us with your feedback. |
This was referenced Jun 19, 2026
This was referenced Jun 26, 2026
Closed
This was referenced Jul 19, 2026
This was referenced Jul 26, 2026
chore(deps): Bump HotChocolate.Subscriptions.InMemory from 15.1.14 to 16.5.1
Kuestenlogik/Bowire#506
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
System.Net.ServerSentEvents(theSseParserAPI) was introduced as a standalone package in .NET 9 but is in-box in the net10.0 shared framework. Referencing it unconditionally trippedNU1510("will not be pruned … likely unnecessary"), which broke the Nitro CLI AOT publish in the Release workflow — that path forces a single-targeted net10.0 restore (-p:TargetFrameworks=net10.0) underTreatWarningsAsErrors.NU1510is not emitted; and it doesn't build the Nitro CLI binary at all.Transport.Http,Fusion.Execution); on net10.0 the in-box type is used.Test plan
NU1510, and compiles against the in-box type.NU1510).