Fix issue in the cost analyzer that deduplicated too aggressively

[michaelstaib]

No description provided.

[Copilot]

Pull request overview

This PR adjusts the cost analysis “response name deduplication” behavior so that repeated response names (e.g., nodes, edges, pageInfo) are only deduplicated within a single selection set, ensuring nested connections and sibling selections are fully costed.

Changes:

• Reset per-selection-set response-name tracking in CostAnalyzer.CalculateSelectionSetCost so nested selection sets can reuse response names without being skipped.
• Add targeted tests covering flat connections, nested fan-out, limit enforcement, and sibling aliased connections.
• Update the existing static query analysis snapshot to reflect the corrected cost calculation.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
src/HotChocolate/CostAnalysis/src/CostAnalysis/CostAnalyzer.cs	Clears the shared Processed set per selection set and reorders the conditional so deduplication happens only after type/field applicability is confirmed.
src/HotChocolate/CostAnalysis/test/CostAnalysis.Tests/NestedConnectionCostTests.cs	Adds regression tests verifying nested and sibling connection costing and cost-limit rejection behavior.
src/HotChocolate/CostAnalysis/test/CostAnalysis.Tests/__snapshots__/StaticQueryAnalysisTests.Execute_ConnectionQuery_ReturnsExpectedResult_0.md	Updates expected operationCost values to match the corrected costing logic.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-code-quality]

Code Coverage Overview

Languages: C#

C# / code-coverage/dotnet

The overall coverage in the mst/cost-issue branch is 49%. Coverage data for the main branch is not yet available.

Show a code coverage summary of the most covered files.

File	main	mst/cost-issue 413cb38	+/-
/home/runner/wo.../FieldResult.cs	—	100%	—
/home/runner/wo...SchemaMerger.cs	—	98%	—
/home/runner/wo...xecutionTree.cs	—	92%	—
/home/runner/wo...ationPlanner.cs	—	88%	—
/home/runner/wo...mentRewriter.cs	—	87%	—
/home/runner/wo...eBuilderBase.cs	—	85%	—
/home/runner/wo...xGenerator.g.cs	—	80%	—
/home/runner/wo...hResultStore.cs	—	80%	—
/home/runner/wo...xGenerator.g.cs	—	71%	—
/home/runner/wo...lient.Client.cs	—	1%	—

---

_{Code Coverage is in Public Preview. Learn more and provide us with your feedback.}