Repository navigation
Bump Marten to 8.37.0 to address GHSA-vmw2-qwm8-x84c - #9777
Merged
Merged
Conversation
github-actions
Bot
added
📚 documentation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the HotChocolate.Data.Marten integration to use Marten 8.37.0 in order to remediate advisory GHSA-vmw2-qwm8-x84c, and aligns tests/docs with the resulting user-visible behavior change for neq filtering on nullable booleans.
Changes:
- Bump
Martenfrom 8.0.0 to 8.37.0 via central package management. - Update nullable-boolean
neqfilter snapshots to reflect Marten’s updated SQL semantics (nulls now match). - Document the behavior change in the v15→v16 migration guide (noted as landing in 16.0.10).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| website/src/docs/hotchocolate/v16/migrating/migrate-from-15-to-16.md | Adds migration note describing the nullable-boolean neq behavior change and its cause. |
| src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/snapshots/QueryableFilterVisitorExecutableTests.Create_NullableBooleanNotEqual_Expression.snap | Updates expected results for executable-based nullable boolean neq filtering to include null rows. |
| src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/snapshots/QueryableFilterVisitorBooleanTests.Create_NullableBooleanNotEqual_Expression.snap | Updates expected results and SQL snapshot for nullable boolean neq filtering under Marten 8.37.0. |
| src/Directory.Packages.props | Central package version bump for Marten to 8.37.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Jun 1, 2026
This was referenced Jun 8, 2026
This was referenced Jun 16, 2026
This was referenced Jun 28, 2026
Closed
This was referenced Jul 5, 2026
This was referenced Aug 31, 2026
This was referenced Sep 8, 2026
This was referenced Sep 17, 2026
This was referenced Sep 28, 2026
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Martenfrom 8.0.0 to 8.37.0 inHotChocolate.Data.Martento address GHSA-vmw2-qwm8-x84c (NU1904).NullableBooleanNotEqual_Expressionsnapshots to reflect Marten 8.10.1's revised!=SQL on nullable booleans (JasperFx/marten#3953): theWHEREclause now includes anIS NULL OR ...branch, soneqresults include rows where the column isNULL.Test plan
dotnet restore src/All.slnx(no NU1904 reported for Marten).dotnet build src/HotChocolate/Marten(0 warnings / 0 errors across net8.0/net9.0/net10.0).dotnet test src/HotChocolate/Marten: 82/82 filters + 24/24 sorting passing on net8.0/net9.0/net10.0 with the updated snapshots.