Repository navigation
Fix false @defer/@stream label collision in reused fragments - #9709
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes validation for @defer/@stream label uniqueness so reused fragments do not falsely collide with themselves during document traversal.
Changes:
- Tracks processed
@defer/@streamdirective nodes to count each lexical directive once. - Adds regression tests for reused fragments with
@deferand@stream. - Adds a snapshot for the remaining valid duplicate-label error case.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/HotChocolate/Core/src/Validation/Rules/DirectiveVisitor.cs |
Adds processed directive tracking to avoid duplicate label validation for the same reused fragment directive. |
src/HotChocolate/Core/test/Validation.Tests/DeferAndStreamDirectiveLabelsAreUniqueTests.cs |
Adds regression tests for reused fragment labels and an outside duplicate. |
src/HotChocolate/Core/test/Validation.Tests/__snapshots__/DeferAndStreamDirectiveLabelsAreUniqueTests.Label_Duplicate_When_Reused_Fragment_Label_Also_Used_Outside.snap |
Captures the expected duplicate-label validation error. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
glen-84
marked this pull request as draft
May 15, 2026 15:01
glen-84
marked this pull request as ready for review
May 19, 2026 15:37
This was referenced May 20, 2026
This was referenced May 27, 2026
This was referenced Jun 28, 2026
Closed
This was referenced Aug 31, 2026
This was referenced Sep 8, 2026
This was referenced Sep 17, 2026
This was referenced Sep 28, 2026
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9705