Skip to content

Fix race condition in DataCompletion with atomic interlocked operations #9407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelstaib merged 2 commits into from
Mar 21, 2026
Merged

Fix race condition in DataCompletion with atomic interlocked operations #9407

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82782c1
Fix race condition in DataCompletion with atomic interlocked operations
michaelstaib Mar 21, 2026
9fb5973
Merge branch 'main' into mst/websocket-race-condition
michaelstaib Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions ...port.Sockets.Client/Protocols/GraphQLOverWebSocket/GraphQLOverWebSocketProtocolHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,17 +151,16 @@ private static MessageType ParseMessageType(ReadOnlySequence<byte> message)

private sealed class DataCompletion(WebSocket socket, string id) : IDataCompletion
{
private bool _completed;
private int _completed;

public void MarkDataStreamCompleted()
=> _completed = true;
=> Interlocked.Exchange(ref _completed, 1);

public void TrySendCompleteMessage()
{
if (!_completed)
if (Interlocked.CompareExchange(ref _completed, 1, 0) == 0)
{
_ = TrySendCompleteMessageInternalAsync(socket, id);
_completed = true;
}
}
}
Expand Down
Loading