Repository navigation
Fix race condition in RequestExecutor creation - #8674
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If two requests come in roughly at the same time. The first request enters the lock to create the request executor.
Once the exeuctor is constructed it's being assigned to the
CurrentExecutorproperty.The second request can now already take the executor without waiting for the lock i.e. the construction to finish.
That's unfortunate, since the
OnConfigureRequestExecutoris run after the property assignment, so theExecutorSessionmight not yet have been associated with the executor, when the second request already tries to use the executor.This PR fixes this, by simply moving the
OnConfigureRequestExecutorbefore theCurrentExecutorassignment.