Groundwork to align type systems. - #8247
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aligns the type system by replacing legacy definition types with new configuration types across HotChocolate’s core, caching, and Apollo Federation projects. Key changes include the removal of the deprecated IOutputType interface, updated method signatures to use TypeSystemConfiguration over DefinitionBase, and systematic renaming of properties and methods from “Definition” to “Configuration” for consistency.
Reviewed Changes
Copilot reviewed 607 out of 608 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/HotChocolate/Core/src/Abstractions/Types/IOutputType.cs | Removed the legacy IOutputType interface. |
| src/HotChocolate/Core/src/Abstractions/IHasReadOnlyContextData.cs | Updated XML comments for clarity. |
| src/HotChocolate/Core/src/Abstractions/Execution/ListPostProcessor.cs | Adjusted condition syntax with the new pattern matching style. |
| src/HotChocolate/Caching/... | Updated method signatures and type references from Definition to Configuration. |
| src/HotChocolate/ApolloFederation/... | Changed type references and method calls to use the new Configuration types across tests, directives, and resolvers. |
| src/HotChocolate/ApolloFederation/Resolvers/ArgumentParser.cs | Modified NonNullType handling to use the updated NullableType property. |
| src/HotChocolate/ApolloFederation/FederationTypeInterceptor.cs | Updated several method parameters and context data handling to reflect the new type system. |
Files not reviewed (1)
- src/HotChocolate/Core/src/Abstractions/HotChocolate.Abstractions.csproj: Language not supported
Comments suppressed due to low confidence (1)
src/HotChocolate/ApolloFederation/src/ApolloFederation/Resolvers/ArgumentParser.cs:33
- Changing from 'nonNullType.Type' to 'nonNullType.NullableType' may affect how non-null types are handled; please verify that this change aligns with the updated type system semantics.
type = type is NonNullType nonNullType ? nonNullType.NullableType : type;
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does some ground work in shifting the Hot Chocolate core over to the new type system abstractions we are using in Mutable and Fusion.