Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect TotalCount for MongoDB #7669

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Fixed incorrect TotalCount for MongoDB #7669

merged 2 commits into from
Nov 4, 2024

Conversation

glen-84
Copy link
Collaborator

@glen-84 glen-84 commented Nov 1, 2024

Summary of the changes (Less than 80 chars)

  • Fixed incorrect TotalCount for MongoDB.

Closes #7642


CountAsync was being run on the sliced query instead of the original query.

⚠️ Change to public interface ICursorPaginationQueryExecutor.

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.83%. Comparing base (ea858cf) to head (1fa8ff0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7669      +/-   ##
==========================================
- Coverage   73.86%   73.83%   -0.03%     
==========================================
  Files        2918     2918              
  Lines      151110   151114       +4     
  Branches    17555    17555              
==========================================
- Hits       111611   111572      -39     
- Misses      33679    33719      +40     
- Partials     5820     5823       +3     
Flag Coverage Δ
unittests 73.83% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TradeeHubDev
Copy link

Hi just checking when will this get merged/released? All my counts on every table are broken so I can't navigate at all @glen-84

@michaelstaib michaelstaib merged commit 28e169d into main Nov 4, 2024
99 checks passed
@michaelstaib michaelstaib deleted the gai/issue-7642 branch November 4, 2024 08:16
@michaelstaib
Copy link
Member

@TradeeHubDev 14.1 will be released this week, the first preview should be out tonight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mongo DB TotalCount for [UsePaging] not working in HC 14
3 participants