Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed QueryResult creation in QueryCacheMiddleware #7441

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Conversation

michaelstaib
Copy link
Member

#6844 broke the existing caching functionality by changing how a QueryResult is being constructed.
This aligns the construction to the new approach.

Fixes #7054

@michaelstaib michaelstaib merged commit 430de4d into main Sep 6, 2024
183 of 190 checks passed
@michaelstaib michaelstaib deleted the mst/cache-fix branch September 6, 2024 17:14
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 32 lines in your changes missing coverage. Please review.

Project coverage is 77.67%. Comparing base (8d63b3e) to head (e8078ed).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ctions/Properties/AbstractionResources.Designer.cs 35.00% 26 Missing ⚠️
...ions/Execution/CleanupExecutionResultExtensions.cs 40.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7441      +/-   ##
==========================================
- Coverage   78.93%   77.67%   -1.26%     
==========================================
  Files        2452     2821     +369     
  Lines      120730   141558   +20828     
==========================================
+ Hits        95304   109962   +14658     
- Misses      25426    31596    +6170     
Flag Coverage Δ
unittests 77.67% <60.00%> (-1.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HotChocolate.Caching 13.9.0 returns empty response
1 participant