Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue that deadlocked DataLoader key batches #7437

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

michaelstaib
Copy link
Member

No description provided.

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 58.82353% with 7 lines in your changes missing coverage. Please review.

Project coverage is 76.28%. Comparing base (8929302) to head (85464d1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/GreenDonut/src/Core/DataLoaderBase.cs 56.25% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7437      +/-   ##
==========================================
- Coverage   78.68%   76.28%   -2.40%     
==========================================
  Files        2452     2825     +373     
  Lines      120715   141636   +20921     
==========================================
+ Hits        94981   108046   +13065     
- Misses      25734    33590    +7856     
Flag Coverage Δ
unittests 76.28% <58.82%> (-2.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelstaib michaelstaib merged commit 0031a06 into main Sep 6, 2024
183 of 188 checks passed
@michaelstaib michaelstaib deleted the mst/DataLoader-list-deadlock branch September 6, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant