Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable introspection by default on non dev environments #7430

Merged
merged 10 commits into from
Sep 4, 2024

Conversation

michaelstaib
Copy link
Member

@michaelstaib michaelstaib commented Sep 4, 2024

  • Schema middleware caches now the SDL per version
  • Schema middleware adds caching headers
  • Introduces new route for schema /graphql/schema.graphql
  • Allows to disable schema middleware with request options
  • Disables introspection when NON dev environment is detected
  • Introduces ISchemaDocumentFormatter so components can reformat the public schema file.

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 93.56725% with 11 lines in your changes missing coverage. Please review.

Project coverage is 77.18%. Comparing base (a88692f) to head (38fced8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...Core/Serialization/DefaultHttpResponseFormatter.cs 86.30% 10 Missing ⚠️
...pNetCore/src/AspNetCore/HttpGetSchemaMiddleware.cs 96.87% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7430      +/-   ##
==========================================
- Coverage   78.87%   77.18%   -1.70%     
==========================================
  Files        2445     2820     +375     
  Lines      120346   141357   +21011     
==========================================
+ Hits        94927   109110   +14183     
- Misses      25419    32247    +6828     
Flag Coverage Δ
unittests 77.18% <93.56%> (-1.70%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelstaib michaelstaib merged commit 45a401e into main Sep 4, 2024
188 of 192 checks passed
@michaelstaib michaelstaib deleted the mst/schema-file branch September 4, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant