Fixed serialization of composite Ids when setting outputNewIdFormat: false #7426
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently I introduced the ability to incrementally adopt the new Id format: a5c1cb1
Underneath it was using the
LegacyNodeIdSerializer
to write Ids in the old format, as long as theoutputNewIdFormat
option was set tofalse
.The
LegacyNodeIdSerializer
doesn't know about customINodeValueSerializer
s though, so you'd end up with a.ToString()
ed version of your Id, instead of the value being transformed by your serializer.This PR changes the behavior of the
outputNewIdFormat
flag, by still using the serializer infrastructure of the new Id format, but outputting the formatted Id with the delimiters of the legacy format.I've also increased the test coverage for the various format / parse cases.