Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow Generic DataLoader when using the source generator #7381

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

michaelstaib
Copy link
Member

fixes #7380

@michaelstaib michaelstaib merged commit 75bd6d5 into main Aug 19, 2024
8 checks passed
@michaelstaib michaelstaib deleted the mst/generic-dataloader branch August 19, 2024 12:52
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.75%. Comparing base (8c21170) to head (b936e3f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7381      +/-   ##
==========================================
+ Coverage   77.11%   78.75%   +1.64%     
==========================================
  Files        2487     2740     +253     
  Lines      123269   135557   +12288     
==========================================
+ Hits        95057   106756   +11699     
- Misses      28212    28801     +589     
Flag Coverage Δ
unittests 78.75% <ø> (+1.64%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minimal DataLoaders - Support generic type in the generated dataLoaders
1 participant