Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Cookie Crumble to ensure that snapshot files end with a newline #7378

Merged
merged 2 commits into from
Aug 18, 2024

Conversation

glen-84
Copy link
Collaborator

@glen-84 glen-84 commented Aug 18, 2024

Summary of the changes (Less than 80 chars)

  • Updated Cookie Crumble to ensure that snapshot files end with a newline.

Copy link

codecov bot commented Aug 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.32%. Comparing base (7b81b8c) to head (be815b6).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7378      +/-   ##
==========================================
- Coverage   77.35%   77.32%   -0.03%     
==========================================
  Files        2481     2793     +312     
  Lines      123062   139421   +16359     
==========================================
+ Hits        95197   107810   +12613     
- Misses      27865    31611    +3746     
Flag Coverage Δ
unittests 77.32% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glen-84 glen-84 force-pushed the gai/cookie-crumble-eof-newline branch 2 times, most recently from b195fd1 to 43b4b9c Compare August 18, 2024 16:11
@glen-84 glen-84 force-pushed the gai/cookie-crumble-eof-newline branch from 43b4b9c to 1114a96 Compare August 18, 2024 16:13
@michaelstaib michaelstaib merged commit df28384 into main Aug 18, 2024
6 checks passed
@michaelstaib michaelstaib deleted the gai/cookie-crumble-eof-newline branch August 18, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants