Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve activity reporting #7354

Merged
merged 5 commits into from
Aug 11, 2024
Merged

Conversation

PascalSenn
Copy link
Member

Closes #7320

Copy link

codecov bot commented Aug 11, 2024

Codecov Report

Attention: Patch coverage is 60.86957% with 9 lines in your changes missing coverage. Please review.

Project coverage is 77.27%. Comparing base (5902ca2) to head (98838b5).

Files Patch % Lines
...te/Diagnostics/src/Diagnostics/ActivityEnricher.cs 60.86% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7354      +/-   ##
==========================================
+ Coverage   77.24%   77.27%   +0.03%     
==========================================
  Files        2461     2787     +326     
  Lines      122152   139107   +16955     
==========================================
+ Hits        94354   107498   +13144     
- Misses      27798    31609    +3811     
Flag Coverage Δ
unittests 77.27% <60.86%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelstaib michaelstaib merged commit 6eced6b into main Aug 11, 2024
183 of 190 checks passed
@michaelstaib michaelstaib deleted the pse/improve-activity-reporting branch August 11, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Follow OTel conventions in default activity enricher
2 participants