Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check in current Fusion error snapshots and unskip tests #7341

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

tobias-tengler
Copy link
Collaborator

Checks in the currently wrong snapshots and keeps the correct snapshots around in a __EXPECTED__ directory.
This will make it easier to iteratively address wrong snapshots, because the changes can be visualized via git diff.

@tobias-tengler tobias-tengler changed the title Check in current snapshots and unskip all error tests Check in current Fusion error snapshots and unskip tests Aug 7, 2024
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.12%. Comparing base (013e7fd) to head (74674d9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7341      +/-   ##
==========================================
- Coverage   77.14%   77.12%   -0.03%     
==========================================
  Files        2474     2786     +312     
  Lines      122769   139074   +16305     
==========================================
+ Hits        94715   107254   +12539     
- Misses      28054    31820    +3766     
Flag Coverage Δ
unittests 77.12% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelstaib michaelstaib merged commit 881f44f into main Aug 7, 2024
184 of 190 checks passed
@michaelstaib michaelstaib deleted the easier-error-snapshots-tests branch August 7, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants