Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated extending-filtering.md #7335

Merged
merged 7 commits into from
Aug 10, 2024
Merged

Conversation

den4ik124
Copy link
Contributor

Constructor QueryableStringInvariantContainsHandler was changed to QueryableStringInvariantEqualsHandler

I hope it was just a typo because of copy-pasting 😅
P.s. sorry in advance if some required steps for page editing were missing

Constructor `QueryableStringInvariantContainsHandler` was changed to `QueryableStringInvariantEqualsHandler`
@CLAassistant
Copy link

CLAassistant commented Aug 5, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the 📚 documentation This issue is about working on our documentation. label Aug 5, 2024
@glen-84
Copy link
Collaborator

glen-84 commented Aug 5, 2024

@den4ik124 Could you please update this in the v14 docs as well? Thanks for your contribution.

@den4ik124
Copy link
Contributor Author

@den4ik124 Could you please update this in the v14 docs as well? Thanks for your contribution.

@glen-84 changes were made for v14 also.

@den4ik124
Copy link
Contributor Author

Sorry @glen-84 , maybe you know what does "action required" means?
https://github.com/ChilliCream/graphql-platform/actions/runs/10246663984

Do I need to do something or someone else need to leave approve on it?

@glen-84
Copy link
Collaborator

glen-84 commented Aug 5, 2024

@den4ik124 We needed to approve the workflow run, which I've done now. Nothing else is required from your side. Thanks.

@glen-84
Copy link
Collaborator

glen-84 commented Aug 7, 2024

@den4ik124 It's not necessary to merge main unless there are conflicts. Thanks.

@michaelstaib michaelstaib changed the title Update extending-filtering.md Updated extending-filtering.md Aug 10, 2024
@michaelstaib michaelstaib merged commit 50b6965 into ChilliCream:main Aug 10, 2024
9 of 11 checks passed
@michaelstaib
Copy link
Member

Thank you for contributing

@den4ik124 den4ik124 deleted the patch-1 branch August 14, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 documentation This issue is about working on our documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants