ChilliCream · michaelstaib · Aug 10, 2024 · Aug 2, 2024 · Aug 2, 2024 · Aug 6, 2024
diff --git a/src/CookieCrumble/src/CookieCrumble/CookieCrumble.csproj b/src/CookieCrumble/src/CookieCrumble/CookieCrumble.csproj
@@ -2,7 +2,6 @@
 
   <PropertyGroup>
     <TargetFrameworks>$(Library2TargetFrameworks)</TargetFrameworks>
-    <Nullable>enable</Nullable>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
     <AssemblyName>CookieCrumble</AssemblyName>
     <RootNamespace>CookieCrumble</RootNamespace>

diff --git a/src/CookieCrumble/test/CookieCrumble.Tests/CookieCrumble.Tests.csproj b/src/CookieCrumble/test/CookieCrumble.Tests/CookieCrumble.Tests.csproj
@@ -2,7 +2,6 @@
 
   <PropertyGroup>
     <TargetFrameworks>$(Library2TargetFrameworks)</TargetFrameworks>
-    <Nullable>enable</Nullable>
 
     <IsPackable>false</IsPackable>
 

diff --git a/src/Directory.Build.props b/src/Directory.Build.props
@@ -6,6 +6,7 @@
     <NoWarn>$(NoWarn);CS0436;RS0026;RS0027;RS0041;AD0001;CS1591;NU5104;NU5128;NU5501</NoWarn>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
     <ImplicitUsings>enable</ImplicitUsings>
+    <Nullable>enable</Nullable>
   </PropertyGroup>
 
   <PropertyGroup Condition="'$(CI)' == 'true'">

diff --git a/src/GreenDonut/src/Core/BatchDataLoader.cs b/src/GreenDonut/src/Core/BatchDataLoader.cs
@@ -1,5 +1,3 @@
-#nullable enable
-
 namespace GreenDonut;
 
 /// <summary>

diff --git a/src/GreenDonut/src/Core/GroupedDataLoader.cs b/src/GreenDonut/src/Core/GroupedDataLoader.cs
@@ -1,5 +1,3 @@
-#nullable enable
-
 namespace GreenDonut;
 
 /// <summary>

diff --git a/src/GreenDonut/src/Directory.Build.props b/src/GreenDonut/src/Directory.Build.props
@@ -4,7 +4,6 @@
 
   <PropertyGroup>
     <TargetFrameworks>$(LibraryTargetFrameworks)</TargetFrameworks>
-    <Nullable>enable</Nullable>
   </PropertyGroup>
 
 </Project>
diff --git a/src/GreenDonut/test/Core.Tests/GreenDonut.Tests.csproj b/src/GreenDonut/test/Core.Tests/GreenDonut.Tests.csproj
@@ -3,6 +3,7 @@
   <PropertyGroup>
     <AssemblyName>GreenDonut.Tests</AssemblyName>
     <RootNamespace>GreenDonut</RootNamespace>
+    <Nullable>disable</Nullable>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/src/HotChocolate/ApolloFederation/Directory.Build.props b/src/HotChocolate/ApolloFederation/Directory.Build.props
@@ -2,7 +2,6 @@
   <Import Project="$([MSBuild]::GetPathOfFileAbove('Directory.Build.props', '$(MSBuildThisFileDirectory)..\'))" />
 
   <PropertyGroup>
-    <Nullable>enable</Nullable>
     <TargetFrameworks>$(Library3TargetFrameworks)</TargetFrameworks>
   </PropertyGroup>
 </Project>
diff --git a/src/HotChocolate/ApolloFederation/src/ApolloFederation/Types/ServerFields.cs b/src/HotChocolate/ApolloFederation/src/ApolloFederation/Types/ServerFields.cs
@@ -1,5 +1,3 @@
-#nullable enable
-
 using HotChocolate.ApolloFederation.Resolvers;
 using HotChocolate.Resolvers;
 using HotChocolate.Types.Descriptors;

diff --git a/...NetCore/src/AspNetCore.Authorization.Opa/HotChocolate.AspNetCore.Authorization.Opa.csproj b/...NetCore/src/AspNetCore.Authorization.Opa/HotChocolate.AspNetCore.Authorization.Opa.csproj
@@ -1,9 +1,5 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
-  <PropertyGroup>
-    <Nullable>enable</Nullable>
-  </PropertyGroup>
-
   <PropertyGroup>
     <PackageId>HotChocolate.AspNetCore.Authorization.Opa</PackageId>
     <AssemblyName>HotChocolate.AspNetCore.Authorization.Opa</AssemblyName>

diff --git a/src/HotChocolate/AspNetCore/src/Directory.Build.props b/src/HotChocolate/AspNetCore/src/Directory.Build.props
@@ -2,8 +2,4 @@
   <Import Project="$([MSBuild]::GetPathOfFileAbove('Directory.Build.props', '$(MSBuildThisFileDirectory)..\'))" />
   <Import Project="$([MSBuild]::GetPathOfFileAbove('Nullable.props', '$(MSBuildThisFileDirectory)..\'))" />
 
-  <PropertyGroup>
-    <Nullable>enable</Nullable>
-  </PropertyGroup>
-
 </Project>
diff --git a/...re/test/AspNetCore.Tests.Utilities/Subscriptions/GraphQLOverWebSocket/SubscribePayload.cs b/...re/test/AspNetCore.Tests.Utilities/Subscriptions/GraphQLOverWebSocket/SubscribePayload.cs
@@ -1,5 +1,3 @@
-#nullable enable
-
 namespace HotChocolate.AspNetCore.Tests.Utilities.Subscriptions.GraphQLOverWebSocket;
 
 public sealed class SubscribePayload

diff --git a/...test/AspNetCore.Tests.Utilities/Subscriptions/GraphQLOverWebSocket/WebSocketExtensions.cs b/...test/AspNetCore.Tests.Utilities/Subscriptions/GraphQLOverWebSocket/WebSocketExtensions.cs
@@ -6,8 +6,6 @@
 using HotChocolate.Utilities;
 using static HotChocolate.Language.Utf8GraphQLRequestParser;
 
-#nullable enable
-
 namespace HotChocolate.AspNetCore.Tests.Utilities.Subscriptions.GraphQLOverWebSocket;
 
 public static class WebSocketExtensions

diff --git a/...Chocolate/AspNetCore/test/AspNetCore.Tests/Subscriptions/Apollo/WebSocketProtocolTests.cs b/...Chocolate/AspNetCore/test/AspNetCore.Tests/Subscriptions/Apollo/WebSocketProtocolTests.cs
@@ -8,8 +8,6 @@
 using Microsoft.AspNetCore.Builder;
 using Microsoft.Extensions.DependencyInjection;
 
-#nullable enable
-
 namespace HotChocolate.AspNetCore.Subscriptions.Apollo;
 
 public class WebSocketProtocolTests : SubscriptionTestBase

diff --git a/...etCore/test/AspNetCore.Tests/Subscriptions/GraphQLOverWebSocket/WebSocketProtocolTests.cs b/...etCore/test/AspNetCore.Tests/Subscriptions/GraphQLOverWebSocket/WebSocketProtocolTests.cs
@@ -12,8 +12,6 @@
 using Xunit.Abstractions;
 using static System.Net.WebSockets.WebSocketCloseStatus;
 
-#nullable enable
-
 namespace HotChocolate.AspNetCore.Subscriptions.GraphQLOverWebSocket;
 
 public class WebSocketProtocolTests : SubscriptionTestBase

diff --git a/src/HotChocolate/AspNetCore/test/Directory.Build.props b/src/HotChocolate/AspNetCore/test/Directory.Build.props
@@ -3,7 +3,6 @@
 
   <PropertyGroup>
     <IsPackable>false</IsPackable>
-    <Nullable>enable</Nullable>
     <GenerateDocumentationFile>false</GenerateDocumentationFile>
   </PropertyGroup>
 

diff --git a/.../test/Transport.Sockets.Client.Tests/GraphQLOverWebSocket/WebSocketClientProtocolTests.cs b/.../test/Transport.Sockets.Client.Tests/GraphQLOverWebSocket/WebSocketClientProtocolTests.cs
@@ -10,8 +10,6 @@
 using Microsoft.Extensions.DependencyInjection;
 using Xunit.Abstractions;
 
-#nullable enable
-
 namespace HotChocolate.Transport.Sockets.GraphQLOverWebSocket;
 
 public class WebSocketClientProtocolTests(TestServerFactory serverFactory, ITestOutputHelper output)

diff --git a/src/HotChocolate/AzureFunctions/Directory.Build.props b/src/HotChocolate/AzureFunctions/Directory.Build.props
@@ -4,7 +4,6 @@
   <PropertyGroup>
     <TargetFrameworks>$(AzfTargetFrameworks)</TargetFrameworks>
     <TargetFrameworks Condition="$(MSBuildProjectName.Contains('Isolated'))">$(AzfIsoProcTargetFrameworks)</TargetFrameworks>
-    <Nullable>enable</Nullable>
   </PropertyGroup>
 
 </Project>
diff --git a/...ocolate.AzureFunctions.IsolatedProcess/HotChocolate.AzureFunctions.IsolatedProcess.csproj b/...ocolate.AzureFunctions.IsolatedProcess/HotChocolate.AzureFunctions.IsolatedProcess.csproj
@@ -5,7 +5,6 @@
     <AssemblyName>HotChocolate.AzureFunctions.IsolatedProcess</AssemblyName>
     <RootNamespace>HotChocolate.AzureFunctions.IsolatedProcess</RootNamespace>
     <Description>This package contains the GraphQL AzureFunctions Isolated Process integration for Hot Chocolate.</Description>
-    <Nullable>enable</Nullable>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/...ocolate/AzureFunctions/src/HotChocolate.AzureFunctions/HotChocolate.AzureFunctions.csproj b/...ocolate/AzureFunctions/src/HotChocolate.AzureFunctions/HotChocolate.AzureFunctions.csproj
@@ -5,7 +5,6 @@
     <AssemblyName>HotChocolate.AzureFunctions</AssemblyName>
     <RootNamespace>HotChocolate.AzureFunctions</RootNamespace>
     <Description>This package contains the GraphQL AzureFunctions integration for Hot Chocolate.</Description>
-    <Nullable>enable</Nullable>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/src/HotChocolate/Caching/Directory.Build.props b/src/HotChocolate/Caching/Directory.Build.props
@@ -2,7 +2,6 @@
   <Import Project="$([MSBuild]::GetPathOfFileAbove('Directory.Build.props', '$(MSBuildThisFileDirectory)..\'))" />
 
   <PropertyGroup>
-    <Nullable>enable</Nullable>
     <TargetFrameworks>$(Library2TargetFrameworks)</TargetFrameworks>
   </PropertyGroup>
 </Project>
diff --git a/src/HotChocolate/Caching/src/Caching/HotChocolate.Caching.csproj b/src/HotChocolate/Caching/src/Caching/HotChocolate.Caching.csproj
@@ -6,7 +6,6 @@
   </ItemGroup>
 
   <PropertyGroup>
-    <Nullable>enable</Nullable>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
   </PropertyGroup>
 

diff --git a/src/HotChocolate/Core/src/Abstractions/HotChocolate.Abstractions.csproj b/src/HotChocolate/Core/src/Abstractions/HotChocolate.Abstractions.csproj
@@ -8,7 +8,6 @@
   </PropertyGroup>
 
   <PropertyGroup>
-    <Nullable>enable</Nullable>
     <EnableTrimAnalyzer Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net8.0'))">true</EnableTrimAnalyzer>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
   </PropertyGroup>

diff --git a/src/HotChocolate/Core/src/Authorization/HotChocolate.Authorization.csproj b/src/HotChocolate/Core/src/Authorization/HotChocolate.Authorization.csproj
@@ -9,7 +9,6 @@
     <AssemblyName>HotChocolate.Authorization</AssemblyName>
     <RootNamespace>HotChocolate.Authorization</RootNamespace>
     <Description>This package contains the authorization abstractions for Hot Chocolate.</Description>
-    <Nullable>enable</Nullable>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/src/HotChocolate/Core/src/Core/HotChocolate.Core.csproj b/src/HotChocolate/Core/src/Core/HotChocolate.Core.csproj
@@ -6,7 +6,6 @@
     <RootNamespace>HotChocolate</RootNamespace>
     <Description>Contains the Hot Chocolate GraphQL query execution engine and query validation.</Description>
     <NoWarn>$(NoWarn);NU5128</NoWarn>
-    <Nullable>enable</Nullable>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/src/HotChocolate/Core/src/Execution.Abstractions/HotChocolate.Execution.Abstractions.csproj b/src/HotChocolate/Core/src/Execution.Abstractions/HotChocolate.Execution.Abstractions.csproj
@@ -6,10 +6,6 @@
     <RootNamespace>HotChocolate.Execution</RootNamespace>
   </PropertyGroup>
 
-  <PropertyGroup>
-    <Nullable>enable</Nullable>
-  </PropertyGroup>
-
   <ItemGroup>
     <ProjectReference Include="..\Abstractions\HotChocolate.Abstractions.csproj" />
   </ItemGroup>

diff --git a/...e/Core/src/Execution/DependencyInjection/SchemaRequestExecutorBuilderExtensions.Paging.cs b/...e/Core/src/Execution/DependencyInjection/SchemaRequestExecutorBuilderExtensions.Paging.cs
@@ -1,8 +1,6 @@
 using HotChocolate.Execution.Configuration;
 using HotChocolate.Types.Pagination;
 
-#nullable enable
-
 // ReSharper disable once CheckNamespace
 namespace Microsoft.Extensions.DependencyInjection;
 

diff --git a/src/HotChocolate/Core/src/Execution/HotChocolate.Execution.csproj b/src/HotChocolate/Core/src/Execution/HotChocolate.Execution.csproj
@@ -1,7 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <Nullable>enable</Nullable>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
   </PropertyGroup>
 

diff --git a/src/HotChocolate/Core/src/Execution/Processing/Result/ResultData.cs b/src/HotChocolate/Core/src/Execution/Processing/Result/ResultData.cs
@@ -1,5 +1,3 @@
-#nullable enable
-
 namespace HotChocolate.Execution.Processing;
 
 /// <summary>

diff --git a/src/HotChocolate/Core/src/Features/HotChocolate.Features.csproj b/src/HotChocolate/Core/src/Features/HotChocolate.Features.csproj
@@ -1,7 +1,3 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
-  <PropertyGroup>
-    <Nullable>enable</Nullable>
-  </PropertyGroup>
-
 </Project>
diff --git a/src/HotChocolate/Core/src/Fetching/Attributes/UseDataLoaderAttribute.cs b/src/HotChocolate/Core/src/Fetching/Attributes/UseDataLoaderAttribute.cs
@@ -2,8 +2,6 @@
 using System.Runtime.CompilerServices;
 using HotChocolate.Types.Descriptors;
 
-#nullable enable
-
 namespace HotChocolate.Types;
 
 public sealed class UseDataLoaderAttribute : ObjectFieldDescriptorAttribute

diff --git a/src/HotChocolate/Core/src/Fetching/Extensions/ObjectFieldDataLoaderExtensions.cs b/src/HotChocolate/Core/src/Fetching/Extensions/ObjectFieldDataLoaderExtensions.cs
@@ -7,8 +7,6 @@
 using static HotChocolate.Fetching.Utilities.ThrowHelper;
 using static HotChocolate.WellKnownMiddleware;
 
-#nullable enable
-
 // ReSharper disable once CheckNamespace
 namespace HotChocolate.Types;
 

diff --git a/src/HotChocolate/Core/src/Fetching/FetchBatch.cs b/src/HotChocolate/Core/src/Fetching/FetchBatch.cs
@@ -1,5 +1,3 @@
-#nullable enable
-
 namespace HotChocolate.Fetching;
 
 public delegate Task<IReadOnlyDictionary<TKey, TValue>> FetchBatch<TKey, TValue>(

diff --git a/src/HotChocolate/Core/src/Fetching/FetchCache.cs b/src/HotChocolate/Core/src/Fetching/FetchCache.cs
@@ -1,5 +1,3 @@
-#nullable enable
-
 namespace HotChocolate.Fetching;
 
 public delegate Task<TValue> FetchCache<in TKey, TValue>(

diff --git a/src/HotChocolate/Core/src/Fetching/FetchGroup.cs b/src/HotChocolate/Core/src/Fetching/FetchGroup.cs
@@ -1,5 +1,3 @@
-#nullable enable
-
 namespace HotChocolate.Fetching;
 
 public delegate Task<ILookup<TKey, TValue>> FetchGroup<TKey, TValue>(

diff --git a/src/HotChocolate/Core/src/Fetching/HotChocolate.Fetching.csproj b/src/HotChocolate/Core/src/Fetching/HotChocolate.Fetching.csproj
@@ -1,9 +1,5 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
-  <PropertyGroup>
-    <Nullable>enable</Nullable>
-  </PropertyGroup>
-
   <PropertyGroup>
     <PackageId>HotChocolate.Fetching</PackageId>
     <AssemblyName>HotChocolate.Fetching</AssemblyName>

diff --git a/src/HotChocolate/Core/src/Subscriptions.InMemory/HotChocolate.Subscriptions.InMemory.csproj b/src/HotChocolate/Core/src/Subscriptions.InMemory/HotChocolate.Subscriptions.InMemory.csproj
@@ -8,7 +8,6 @@
   </PropertyGroup>
 
   <PropertyGroup>
-    <Nullable>enable</Nullable>
     <TargetFrameworks>$(Library2TargetFrameworks)</TargetFrameworks>
   </PropertyGroup>
 

diff --git a/src/HotChocolate/Core/src/Subscriptions.Nats/HotChocolate.Subscriptions.Nats.csproj b/src/HotChocolate/Core/src/Subscriptions.Nats/HotChocolate.Subscriptions.Nats.csproj
@@ -8,7 +8,6 @@
   </PropertyGroup>
 
   <PropertyGroup>
-    <Nullable>enable</Nullable>
     <TargetFrameworks>$(Library2TargetFrameworks)</TargetFrameworks>
   </PropertyGroup>
 

diff --git a/src/HotChocolate/Core/src/Subscriptions.Postgres/HotChocolate.Subscriptions.Postgres.csproj b/src/HotChocolate/Core/src/Subscriptions.Postgres/HotChocolate.Subscriptions.Postgres.csproj
@@ -8,7 +8,6 @@
   </PropertyGroup>
 
   <PropertyGroup>
-    <Nullable>enable</Nullable>
     <TargetFrameworks>$(Library3TargetFrameworks)</TargetFrameworks>
   </PropertyGroup>
 

diff --git a/src/HotChocolate/Core/src/Subscriptions.RabbitMQ/HotChocolate.Subscriptions.RabbitMQ.csproj b/src/HotChocolate/Core/src/Subscriptions.RabbitMQ/HotChocolate.Subscriptions.RabbitMQ.csproj
@@ -8,7 +8,6 @@
   </PropertyGroup>
 
   <PropertyGroup>
-    <Nullable>enable</Nullable>
     <TargetFrameworks>$(Library2TargetFrameworks)</TargetFrameworks>
   </PropertyGroup>
 

diff --git a/src/HotChocolate/Core/src/Subscriptions.Redis/HotChocolate.Subscriptions.Redis.csproj b/src/HotChocolate/Core/src/Subscriptions.Redis/HotChocolate.Subscriptions.Redis.csproj
@@ -8,7 +8,6 @@
   </PropertyGroup>
 
   <PropertyGroup>
-    <Nullable>enable</Nullable>
     <TargetFrameworks>$(Library2TargetFrameworks)</TargetFrameworks>
   </PropertyGroup>
 

diff --git a/...criptions.Serializers.Newtonsoft/HotChocolate.Subscriptions.Serializers.Newtonsoft.csproj b/...criptions.Serializers.Newtonsoft/HotChocolate.Subscriptions.Serializers.Newtonsoft.csproj
@@ -8,7 +8,6 @@
   </PropertyGroup>
 
   <PropertyGroup>
-    <Nullable>enable</Nullable>
     <TargetFrameworks>$(Library2TargetFrameworks)</TargetFrameworks>
   </PropertyGroup>
 

diff --git a/src/HotChocolate/Core/src/Subscriptions/HotChocolate.Subscriptions.csproj b/src/HotChocolate/Core/src/Subscriptions/HotChocolate.Subscriptions.csproj
@@ -8,7 +8,6 @@
   </PropertyGroup>
 
   <PropertyGroup>
-    <Nullable>enable</Nullable>
     <TargetFrameworks>$(Library2TargetFrameworks)</TargetFrameworks>
   </PropertyGroup>
 

diff --git a/src/HotChocolate/Core/src/Types.Analyzers/HotChocolate.Types.Analyzers.csproj b/src/HotChocolate/Core/src/Types.Analyzers/HotChocolate.Types.Analyzers.csproj
@@ -3,7 +3,6 @@
   <PropertyGroup>
     <TargetFrameworks>netstandard2.0</TargetFrameworks>
     <TargetFramework>netstandard2.0</TargetFramework>
-    <Nullable>enable</Nullable>
     <IncludeBuildOutput>false</IncludeBuildOutput> <!-- Do not include the generator as a lib dependency -->
     <IncludeSymbols>false</IncludeSymbols>
     <EnforceExtendedAnalyzerRules>true</EnforceExtendedAnalyzerRules>

diff --git a/src/HotChocolate/Core/src/Types.CursorPagination/ConnectionType.cs b/src/HotChocolate/Core/src/Types.CursorPagination/ConnectionType.cs
@@ -1,5 +1,3 @@
-#nullable enable
-
 using HotChocolate.Configuration;
 using HotChocolate.Resolvers;
 using HotChocolate.Types.Descriptors;

diff --git a/src/HotChocolate/Core/src/Types.CursorPagination/HotChocolate.Types.CursorPagination.csproj b/src/HotChocolate/Core/src/Types.CursorPagination/HotChocolate.Types.CursorPagination.csproj
@@ -1,7 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <Nullable>enable</Nullable>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
   </PropertyGroup>
 

diff --git a/src/HotChocolate/Core/src/Types.CursorPagination/IndexEdge.cs b/src/HotChocolate/Core/src/Types.CursorPagination/IndexEdge.cs
@@ -1,7 +1,5 @@
 using System.Buffers.Text;
 
-#nullable enable
-
 namespace HotChocolate.Types.Pagination;
 
 public sealed class IndexEdge<T> : Edge<T>

diff --git a/src/HotChocolate/Core/src/Types.Errors/HotChocolate.Types.Errors.csproj b/src/HotChocolate/Core/src/Types.Errors/HotChocolate.Types.Errors.csproj
@@ -1,9 +1,5 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
-  <PropertyGroup>
-    <Nullable>enable</Nullable>
-  </PropertyGroup>
-
   <PropertyGroup>
     <PackageId>HotChocolate.Types.Errors</PackageId>
     <AssemblyName>HotChocolate.Types.Errors</AssemblyName>

diff --git a/src/HotChocolate/Core/src/Types.Json/HotChocolate.Types.Json.csproj b/src/HotChocolate/Core/src/Types.Json/HotChocolate.Types.Json.csproj
@@ -1,7 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <Nullable>enable</Nullable>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
   </PropertyGroup>