Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the DateTime scalar to enforce a specific format #7329

Merged
merged 3 commits into from
Aug 2, 2024

Conversation

glen-84
Copy link
Collaborator

@glen-84 glen-84 commented Aug 2, 2024

Summary of the changes (Less than 80 chars)

  • Updated the DateTime scalar to enforce a specific format.

Closes #6276


Differences to DateTime Scalar spec:

  • Fractions of a second are optional, and 0-7 digits may be specified.

Differences to RFC 3339:

⚠️ Breaking change.

@glen-84 glen-84 marked this pull request as draft August 2, 2024 14:41
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.09%. Comparing base (0b209c3) to head (e606016).

Files Patch % Lines
...olate/Core/src/Types/Types/Scalars/DateTimeType.cs 82.35% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7329      +/-   ##
==========================================
+ Coverage   77.04%   77.09%   +0.04%     
==========================================
  Files        2459     2781     +322     
  Lines      121972   138774   +16802     
==========================================
+ Hits        93968   106981   +13013     
- Misses      28004    31793    +3789     
Flag Coverage Δ
unittests 77.09% <82.35%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glen-84 glen-84 marked this pull request as ready for review August 2, 2024 15:08
@michaelstaib michaelstaib merged commit a9ad558 into main Aug 2, 2024
181 of 188 checks passed
@michaelstaib michaelstaib deleted the gai/issue-6276 branch August 2, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraphQL DateTime scalar should throw when no offset is specified
2 participants