Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ContinuousTask test #7316

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Fixed ContinuousTask test #7316

merged 2 commits into from
Aug 13, 2024

Conversation

glen-84
Copy link
Collaborator

@glen-84 glen-84 commented Jul 31, 2024

Summary of the changes (Less than 80 chars)

  • Fixed ContinuousTask test.

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.30%. Comparing base (5902ca2) to head (7914b5c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7316      +/-   ##
==========================================
- Coverage   77.24%   75.30%   -1.94%     
==========================================
  Files        2461     2787     +326     
  Lines      122152   139110   +16958     
==========================================
+ Hits        94354   104757   +10403     
- Misses      27798    34353    +6555     
Flag Coverage Δ
unittests 75.30% <100.00%> (-1.94%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glen-84 glen-84 force-pushed the gai/fix-continuous-task-test branch from e391c65 to 7914b5c Compare August 11, 2024 10:03
Copy link
Member

@PascalSenn PascalSenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glen-84 glen-84 marked this pull request as ready for review August 11, 2024 10:35
@michaelstaib michaelstaib merged commit 3665fcb into main Aug 13, 2024
5 checks passed
@michaelstaib michaelstaib deleted the gai/fix-continuous-task-test branch August 13, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants