Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed --property WarningLevel=0 in CI builds #7298

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

glen-84
Copy link
Collaborator

@glen-84 glen-84 commented Jul 24, 2024

Summary of the changes (Less than 80 chars)

  • Removed --property WarningLevel=0 in CI builds.

The build should fail until #7297 is merged.

@glen-84 glen-84 marked this pull request as draft July 24, 2024 13:03
@glen-84
Copy link
Collaborator Author

glen-84 commented Jul 24, 2024

There are some other warnings. Looking into it now.

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.73%. Comparing base (2bd5ec7) to head (fef0d3b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7298      +/-   ##
==========================================
+ Coverage   76.70%   76.73%   +0.03%     
==========================================
  Files        2459     2771     +312     
  Lines      121659   137883   +16224     
==========================================
+ Hits        93317   105809   +12492     
- Misses      28342    32074    +3732     
Flag Coverage Δ
unittests 76.73% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glen-84 glen-84 marked this pull request as ready for review July 24, 2024 14:08
@michaelstaib michaelstaib merged commit d65c9b9 into main Jul 24, 2024
181 of 190 checks passed
@michaelstaib michaelstaib deleted the gai/remove-warning-level branch July 24, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants