Added DataLoader source generator snapshot tests #7290
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes (Less than 80 chars)
ℹ️ Notes:
Basic.Reference.Assemblies
, as an alternative to loading all assemblies in the AppDomain (like this). I'm not sure which is the better option.❓ Questions:
CacheDataLoader
being generated – am I doing something wrong? Is the DataLoader type not based on the method signature?_services.GetRequiredService
– should it be using thect
parameter ofLoadSingleAsync
instead?HotChocolateMiddleware.735550c.g.cs
has a variable GUID suffix – is that important? For now, I've added code to replace it withHASH
in the snapshots.HotChocolate.Types.Analyzers.Tests
project – can theHotChocolate.Types.Analyzers.DataLoader.Tests
project be deleted?