Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fusion] Add FusionGatewayBuilder.UseRequest #7283

Merged
merged 11 commits into from
Jul 25, 2024
Merged

Conversation

tobias-tengler
Copy link
Collaborator

We want to append a custom request middleware. Currently we have to drop down to the IRequestExecutorBuilder and replicate the entire FusionGateway.UsePersistedQueryPipeline contents in user space.

This change would allow us to do:

builder
    .UseRequest<CustomMiddleware>()
    .UsePersistedQueryPipeline()

Copy link

codecov bot commented Jul 20, 2024

Codecov Report

Attention: Patch coverage is 21.42857% with 22 lines in your changes missing coverage. Please review.

Project coverage is 75.75%. Comparing base (b91ddb7) to head (9673d68).
Report is 13 commits behind head on main.

Files Patch % Lines
...njection/FusionRequestExecutorBuilderExtensions.cs 21.42% 22 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7283      +/-   ##
==========================================
- Coverage   78.84%   75.75%   -3.10%     
==========================================
  Files        2421     2771     +350     
  Lines      118431   137910   +19479     
==========================================
+ Hits        93379   104467   +11088     
- Misses      25052    33443    +8391     
Flag Coverage Δ
unittests 75.75% <21.42%> (-3.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tobias-tengler tobias-tengler changed the title Add FusionGatewayBuilder.UseRequest [Fusion] Add FusionGatewayBuilder.UseRequest Jul 20, 2024
@tobias-tengler tobias-tengler added the 👓 ready-for-review The PR is ready for review. label Jul 20, 2024
@michaelstaib
Copy link
Member

@tobias-tengler we need one test for this.

@michaelstaib michaelstaib merged commit da81525 into main Jul 25, 2024
3 checks passed
@michaelstaib michaelstaib deleted the tte/fusion-use-request branch July 25, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants