Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated NameUtils.GetEnumValue to preserve leading underscore #7272

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

glen-84
Copy link
Collaborator

@glen-84 glen-84 commented Jul 16, 2024

Summary of the changes (Less than 80 chars)

  • Updated NameUtils.GetEnumValue to preserve leading underscore.

Closes #4771


⚠️ Breaking change (minor)

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 76.08%. Comparing base (d99f878) to head (54fbbfb).

Files Patch % Lines
...neration/src/CodeGeneration/Utilities/NameUtils.cs 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7272      +/-   ##
==========================================
+ Coverage   76.05%   76.08%   +0.03%     
==========================================
  Files        2399     2711     +312     
  Lines      117868   134183   +16315     
==========================================
+ Hits        89639   102092   +12453     
- Misses      28229    32091    +3862     
Flag Coverage Δ
unittests 76.08% <25.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelstaib michaelstaib merged commit 0605e2a into main Jul 19, 2024
3 checks passed
@michaelstaib michaelstaib deleted the gai/issue-4771 branch July 19, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Enum values starting with underscore
2 participants