Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled TreatWarningsAsErrors in CI, and disabled it elsewhere #7263

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

glen-84
Copy link
Collaborator

@glen-84 glen-84 commented Jul 12, 2024

Summary of the changes (Less than 80 chars)

  • Enabled TreatWarningsAsErrors in CI, and disabled it elsewhere.

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.19%. Comparing base (3b950a7) to head (8fa83d9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7263      +/-   ##
==========================================
- Coverage   78.81%   76.19%   -2.63%     
==========================================
  Files        2403     2715     +312     
  Lines      118488   134799   +16311     
==========================================
+ Hits        93390   102710    +9320     
- Misses      25098    32089    +6991     
Flag Coverage Δ
unittests 76.19% <ø> (-2.63%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelstaib michaelstaib merged commit 0154f8b into main Jul 15, 2024
4 checks passed
@michaelstaib michaelstaib deleted the gai/warnings-as-errors branch July 15, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants