Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed cycle detection in AnyType and ObjectToDictionaryConverter #7262

Merged
merged 5 commits into from
Aug 6, 2024

Conversation

glen-84
Copy link
Collaborator

@glen-84 glen-84 commented Jul 11, 2024

Summary of the changes (Less than 80 chars)

  • Fixed cycle detection in AnyType and ObjectToDictionaryConverter.

Closes #7227

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.10%. Comparing base (492c853) to head (5988394).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7262      +/-   ##
==========================================
- Coverage   77.13%   77.10%   -0.03%     
==========================================
  Files        2474     2786     +312     
  Lines      122758   139071   +16313     
==========================================
+ Hits        94687   107229   +12542     
- Misses      28071    31842    +3771     
Flag Coverage Δ
unittests 77.10% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glen-84 glen-84 changed the title Used reference equality when tracking processed objects Fixed cycle detection in AnyType and ObjectToDictionaryConverter Aug 5, 2024
@glen-84 glen-84 marked this pull request as ready for review August 5, 2024 15:57
@michaelstaib michaelstaib merged commit 4223f76 into main Aug 6, 2024
5 checks passed
@michaelstaib michaelstaib deleted the gai/issue-7227 branch August 6, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AnyType omits values that are equal to values that are already written to the output
2 participants